added translation for unavailable ip

Kira-Pilot · Kira-Pilot · commit b10141756bef · 2022-11-28T17:03:53.000Z
diff --git a/site/src/components/AuditLogRow/AuditLogRow.tsx b/site/src/components/AuditLogRow/AuditLogRow.tsx
@@ -64,10 +64,9 @@ export const AuditLogRow: React.FC<AuditLogRowProps> = ({
   const diffs = Object.entries(auditLog.diff)
   const shouldDisplayDiff = diffs.length > 0
   const { os, browser } = userAgentParser(auditLog.user_agent)
-  const notAvailableLabel = "Not available"
   const displayBrowserInfo = browser.name
     ? `${browser.name} ${browser.version}`
-    : notAvailableLabel
+    : t("auditLog:table.logRow.notAvailable")
 
   const toggle = () => {
     if (shouldDisplayDiff) {
@@ -148,12 +147,21 @@ export const AuditLogRow: React.FC<AuditLogRowProps> = ({
                   <Stack direction="row" spacing={1} alignItems="baseline">
                     <span className={styles.auditLogInfo}>
                       <>{t("auditLog:table.logRow.ip")}</>
-                      <strong>{auditLog.ip ?? notAvailableLabel}</strong>
+                      <strong>
+                        {auditLog.ip
+                          ? auditLog.ip
+                          : t("auditLog:table.logRow.notAvailable")}
+                      </strong>
                     </span>
 
                     <span className={styles.auditLogInfo}>
                       <>{t("auditLog:table.logRow.os")}</>
-                      <strong>{os.name ?? notAvailableLabel}</strong>
+                      <strong>
+                        {os.name
+                          ? os.name
+                          : // https://github.com/i18next/next-i18next/issues/1795
+                            t<string>("auditLog:table.logRow.notAvailable")}
+                      </strong>
                     </span>
 
                     <span className={styles.auditLogInfo}>
diff --git a/site/src/i18n/en/auditLog.json b/site/src/i18n/en/auditLog.json
@@ -12,7 +12,8 @@
       "buildFriendlyString": " for workspace ",
       "ip": "IP: ",
       "os": "OS: ",
-      "browser": "Browser: "
+      "browser": "Browser: ",
+      "notAvailable": "Not available"
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,8 @@`
`12`	`12`	`"buildFriendlyString": " for workspace ",`
`13`	`13`	`"ip": "IP: ",`
`14`	`14`	`"os": "OS: ",`
`15`		`- "browser": "Browser: "`
	`15`	`+ "browser": "Browser: ",`
	`16`	`+ "notAvailable": "Not available"`
`16`	`17`	`}`
`17`	`18`	`}`
`18`	`19`	`}`