fix: Remove explicit coverpkg github.com/coder/coder/codersdk

mafredri · mafredri · commit b16039ccc60b · 2022-06-29T16:21:55.000+03:00
This package is already covered by ./...
diff --git a/.github/workflows/coder.yaml b/.github/workflows/coder.yaml
@@ -204,7 +204,7 @@ jobs:
         shell: bash
         run: gotestsum --junitfile="gotests.xml" --packages="./..." --
           -covermode=atomic -coverprofile="gotests.coverage"
-          -coverpkg=./...,github.com/coder/coder/codersdk
+          -coverpkg=./...
           -timeout=5m -short -failfast
 
       - name: Upload DataDog Trace
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -117,7 +117,9 @@
   "go.coverOnSave": true,
   // The codersdk is used by coderd another other packages extensively.
   // To reduce redundancy in tests, it's covered by other packages.
-  "go.testFlags": ["-short", "-coverpkg=./.,github.com/coder/coder/codersdk"],
+  // Since package coverage pairing can't be defined, all packages cover
+  // all other packages.
+  "go.testFlags": ["-short", "-coverpkg=./..."],
   "go.coverageDecorator": {
     "type": "gutter",
     "coveredHighlightColor": "rgba(64,128,128,0.5)",
diff --git a/Makefile b/Makefile
@@ -174,7 +174,7 @@ test: test-clean
 test-postgres: test-clean test-postgres-docker
 	DB=ci DB_FROM=$(shell go run scripts/migrate-ci/main.go) gotestsum --junitfile="gotests.xml" --packages="./..." -- \
 		-covermode=atomic -coverprofile="gotests.coverage" -timeout=30m \
-		-coverpkg=./...,github.com/coder/coder/codersdk \
+		-coverpkg=./... \
 		-count=2 -race -failfast
 .PHONY: test-postgres
 
