Skip to content

Commit b228257

Browse files
committed
provide a key to provisioner tags to keep react happy
1 parent 0cab768 commit b228257

File tree

2 files changed

+18
-2
lines changed

2 files changed

+18
-2
lines changed

site/src/modules/provisioners/ProvisionerAlert.stories.tsx

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,20 @@ export const HealthyProvisioners: Story = {
2727
}
2828
};
2929

30+
export const UndefinedMatchingProvisioners: Story = {
31+
args: {
32+
matchingProvisioners: undefined,
33+
availableProvisioners: undefined
34+
}
35+
};
36+
37+
export const UndefinedAvailableProvisioners: Story = {
38+
args: {
39+
matchingProvisioners: 1,
40+
availableProvisioners: undefined
41+
}
42+
};
43+
3044
export const NoMatchingProvisioners: Story = {
3145
args: {
3246
matchingProvisioners: 0,

site/src/modules/provisioners/ProvisionerAlert.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ export const ProvisionerAlert : FC<ProvisionerAlertProps> = ({
4848
.filter(([key]) => key !== "owner")
4949
.map(([key, value]) => (
5050
<ProvisionerTag
51+
key={key}
5152
tagName={key}
5253
tagValue={value}
5354
/>
@@ -58,14 +59,14 @@ export const ProvisionerAlert : FC<ProvisionerAlertProps> = ({
5859
);
5960
};
6061

61-
interface ProvisionerJobErrorProps {
62+
interface ProvisionerJobAlertProps {
6263
title: string
6364
detail: string
6465
severity: AlertColor
6566
tags: Record<string, string>
6667
}
6768

68-
export const ProvisionerJobAlert : FC<ProvisionerJobErrorProps> = ({
69+
export const ProvisionerJobAlert : FC<ProvisionerJobAlertProps> = ({
6970
title,
7071
detail,
7172
severity,
@@ -89,6 +90,7 @@ export const ProvisionerJobAlert : FC<ProvisionerJobErrorProps> = ({
8990
.filter(([key]) => key !== "owner")
9091
.map(([key, value]) => (
9192
<ProvisionerTag
93+
key={key}
9294
tagName={key}
9395
tagValue={value}
9496
/>

0 commit comments

Comments
 (0)