chore: fix ruleguard xerrors rules (#8967)

deansheather · web-flow · commit b2a84462abb6 · 2023-08-08T12:32:41.000Z
diff --git a/cli/stat.go b/cli/stat.go
@@ -240,7 +240,7 @@ func (*RootCmd) statDisk(s *clistat.Statter) *clibase.Cmd {
 			ds, err := s.Disk(pfx, pathArg)
 			if err != nil {
 				if os.IsNotExist(err) {
-					// fmt.Errorf produces a more concise error.
+					//nolint:gocritic // fmt.Errorf produces a more concise error.
 					return fmt.Errorf("not found: %q", pathArg)
 				}
 				return err
diff --git a/scripts/rules.go b/scripts/rules.go
@@ -51,8 +51,12 @@ func xerrors(m dsl.Matcher) {
 	m.Import("fmt")
 	m.Import("golang.org/x/xerrors")
 
-	m.Match("fmt.Errorf($*args)").
-		Suggest("xerrors.New($args)").
+	m.Match("fmt.Errorf($arg)").
+		Suggest("xerrors.New($arg)").
+		Report("Use xerrors to provide additional stacktrace information!")
+
+	m.Match("fmt.Errorf($arg1, $*args)").
+		Suggest("xerrors.Errorf($arg1, $args)").
 		Report("Use xerrors to provide additional stacktrace information!")
 
 	m.Match("errors.$_($msg)").

Original file line number	Diff line number	Diff line change
`@@ -240,7 +240,7 @@ func (RootCmd) statDisk(s clistat.Statter) *clibase.Cmd {`
`240`	`240`	`ds, err := s.Disk(pfx, pathArg)`
`241`	`241`	`if err != nil {`
`242`	`242`	`if os.IsNotExist(err) {`
`243`		`- // fmt.Errorf produces a more concise error.`
	`243`	`+ //nolint:gocritic // fmt.Errorf produces a more concise error.`
`244`	`244`	`return fmt.Errorf("not found: %q", pathArg)`
`245`	`245`	`}`
`246`	`246`	`return err`