Fix early return

kylecarbs · kylecarbs · commit b2d2e8218fd9 · 2023-02-02T16:14:18.000Z
diff --git a/testutil/eventually.go b/testutil/eventually.go
@@ -32,9 +32,9 @@ func Eventually(ctx context.Context, t testing.TB, condition func(ctx context.Co
 	if len(msgAndArgs) > 0 {
 		if m, ok := msgAndArgs[0].(string); ok {
 			msg = fmt.Sprintf(m, msgAndArgs[1:]...)
-		} else {
-			panic("developer error: first argument of msgAndArgs must be a string")
+			return
 		}
+		panic("developer error: first argument of msgAndArgs must be a string")
 	}
 
 	ticker := time.NewTicker(tick)

Original file line number	Diff line number	Diff line change
`@@ -32,9 +32,9 @@ func Eventually(ctx context.Context, t testing.TB, condition func(ctx context.Co`
`32`	`32`	`if len(msgAndArgs) > 0 {`
`33`	`33`	`if m, ok := msgAndArgs[0].(string); ok {`
`34`	`34`	`msg = fmt.Sprintf(m, msgAndArgs[1:]...)`
`35`		`- } else {`
`36`		`- panic("developer error: first argument of msgAndArgs must be a string")`
	`35`	`+ return`
`37`	`36`	`}`
	`37`	`+ panic("developer error: first argument of msgAndArgs must be a string")`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`ticker := time.NewTicker(tick)`