Remove unused interface implementation check

sreya · sreya · commit b33616e6e4c5 · 2024-10-04T06:56:24.000Z
The unused `cryptokeys.Keycache` interface implementation check was removed from the `CryptoKeyCache` struct, as it was unnecessary and did not contribute to functionality. This streamlines the code and adheres to best practices for interface checks.
diff --git a/enterprise/wsproxy/keycache.go b/enterprise/wsproxy/keycache.go
@@ -25,8 +25,6 @@ type Fetcher interface {
 	Fetch(ctx context.Context) ([]codersdk.CryptoKey, error)
 }
 
-var _ cryptokeys.Keycache = &CryptoKeyCache{}
-
 type CryptoKeyCache struct {
 	Clock         quartz.Clock
 	refreshCtx    context.Context
diff --git a/enterprise/wsproxy/keycache_test.go b/enterprise/wsproxy/keycache_test.go
@@ -473,7 +473,7 @@ type fakeFetcher struct {
 	called int
 }
 
-func (f *fakeFetcher) Fetch(ctx context.Context) ([]codersdk.CryptoKey, error) {
+func (f *fakeFetcher) Fetch(_ context.Context) ([]codersdk.CryptoKey, error) {
 	f.called++
 	return f.keys, nil
 }

Original file line number	Diff line number	Diff line change
`@@ -25,8 +25,6 @@ type Fetcher interface {`
`25`	`25`	`Fetch(ctx context.Context) ([]codersdk.CryptoKey, error)`
`26`	`26`	`}`
`27`	`27`
`28`		`-var _ cryptokeys.Keycache = &CryptoKeyCache{}`
`29`		`-`
`30`	`28`	`type CryptoKeyCache struct {`
`31`	`29`	`Clock quartz.Clock`
`32`	`30`	`refreshCtx context.Context`
Original file line number	Diff line number	Diff line change
`@@ -473,7 +473,7 @@ type fakeFetcher struct {`
`473`	`473`	`called int`
`474`	`474`	`}`
`475`	`475`
`476`		`-func (f *fakeFetcher) Fetch(ctx context.Context) ([]codersdk.CryptoKey, error) {`
	`476`	`+func (f *fakeFetcher) Fetch(_ context.Context) ([]codersdk.CryptoKey, error) {`
`477`	`477`	`f.called++`
`478`	`478`	`return f.keys, nil`
`479`	`479`	`}`