chore: Rbac errors should be returned, and not hidden behind 404

Emyrk · Emyrk · commit b33e7f61e63e · 2023-04-13T10:31:53.000-05:00
SqlErrNoRows was hiding actual errors
diff --git a/coderd/database/dbauthz/dbauthz.go b/coderd/database/dbauthz/dbauthz.go
@@ -34,8 +34,8 @@ func (e NotAuthorizedError) Error() string {
 
 // Unwrap will always unwrap to a sql.ErrNoRows so the API returns a 404.
 // So 'errors.Is(err, sql.ErrNoRows)' will always be true.
-func (NotAuthorizedError) Unwrap() error {
-	return sql.ErrNoRows
+func (e NotAuthorizedError) Unwrap() error {
+	return e.Err
 }
 
 func IsNotAuthorizedError(err error) bool {

Original file line number	Diff line number	Diff line change
`@@ -34,8 +34,8 @@ func (e NotAuthorizedError) Error() string {`
`34`	`34`
`35`	`35`	`// Unwrap will always unwrap to a sql.ErrNoRows so the API returns a 404.`
`36`	`36`	`// So 'errors.Is(err, sql.ErrNoRows)' will always be true.`
`37`		`-func (NotAuthorizedError) Unwrap() error {`
`38`		`- return sql.ErrNoRows`
	`37`	`+func (e NotAuthorizedError) Unwrap() error {`
	`38`	`+ return e.Err`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`func IsNotAuthorizedError(err error) bool {`