fix: Stop multiple buttons from compounding in the workspace action dropdown (#3482)

kylecarbs · web-flow · commit b3d3b8ba0f7e · 2022-08-12T13:19:52.000Z
The variadic function on an object doesn't clone the inner array. This was causing the `secondary` property to accumulate more and more button types as time went on! Fixes #3154.
diff --git a/site/src/components/WorkspaceActions/WorkspaceActions.tsx b/site/src/components/WorkspaceActions/WorkspaceActions.tsx
@@ -68,7 +68,7 @@ export const WorkspaceActions: FC<WorkspaceActionsProps> = ({
     // if an update is available, we make the update button the primary CTA
     // and move the former primary CTA to the secondary actions list
     const updatedActions = { ...WorkspaceStateActions[workspaceState] }
-    updatedActions.secondary.unshift(updatedActions.primary)
+    updatedActions.secondary = [updatedActions.primary, ...updatedActions.secondary]
     updatedActions.primary = ButtonTypesEnum.update
 
     return updatedActions
