fix: Run Tailnet SSH connections in a goroutine

kylecarbs · kylecarbs · commit b4b10b097bc6 · 2022-09-02T10:53:52.000-05:00
This was causing SSH connections in parallel to fail 🤦!
diff --git a/agent/agent.go b/agent/agent.go
@@ -219,7 +219,7 @@ func (a *agent) runTailnet(ctx context.Context, derpMap *tailcfg.DERPMap) {
 			if err != nil {
 				return
 			}
-			a.sshServer.HandleConn(a.stats.wrapConn(conn))
+			go a.sshServer.HandleConn(a.stats.wrapConn(conn))
 		}
 	}()
 	reconnectingPTYListener, err := a.network.Listen("tcp", ":"+strconv.Itoa(tailnetReconnectingPTYPort))

Original file line number	Diff line number	Diff line change
`@@ -219,7 +219,7 @@ func (a agent) runTailnet(ctx context.Context, derpMap tailcfg.DERPMap) {`
`219`	`219`	`if err != nil {`
`220`	`220`	`return`
`221`	`221`	`}`
`222`		`- a.sshServer.HandleConn(a.stats.wrapConn(conn))`
	`222`	`+ go a.sshServer.HandleConn(a.stats.wrapConn(conn))`
`223`	`223`	`}`
`224`	`224`	`}()`
`225`	`225`	`reconnectingPTYListener, err := a.network.Listen("tcp", ":"+strconv.Itoa(tailnetReconnectingPTYPort))`