pre-allocate map

defelmnq · defelmnq · commit b5ff46568772 · 2024-11-25T06:41:22.000Z
diff --git a/enterprise/cli/provisionerdaemonstart.go b/enterprise/cli/provisionerdaemonstart.go
@@ -104,14 +104,20 @@ func (r *RootCmd) provisionerDaemonStart() *serpent.Command {
 				return err
 			}
 
+			displayedTags := make(map[string]string, len(tags))
+			for key, val := range tags {
+				displayedTags[key] = val
+			}
+
 			if provisionerKey != "" {
 				pkDetails, err := client.GetProvisionerKey(ctx, provisionerKey)
 				if err != nil {
-					return xerrors.Errorf("unable to get provisioner key details: %w", err)
+					return xerrors.New("unable to get provisioner key details")
 				}
 
+				displayedTags = make(map[string]string, len(pkDetails.Tags))
 				for k, v := range pkDetails.Tags {
-					tags[k] = v
+					displayedTags[k] = v
 				}
 			}
 
@@ -142,7 +148,7 @@ func (r *RootCmd) provisionerDaemonStart() *serpent.Command {
 				defer closeLogger()
 			}
 
-			if len(tags) == 0 {
+			if len(displayedTags) == 0 {
 				logger.Info(ctx, "note: untagged provisioners can only pick up jobs from untagged templates")
 			}
 
@@ -213,7 +219,7 @@ func (r *RootCmd) provisionerDaemonStart() *serpent.Command {
 				defer closeFunc()
 			}
 
-			logger.Info(ctx, "starting provisioner daemon", slog.F("tags", tags), slog.F("name", name))
+			logger.Info(ctx, "starting provisioner daemon", slog.F("tags", displayedTags), slog.F("name", name))
 
 			connector := provisionerd.LocalProvisioners{
 				string(database.ProvisionerTypeTerraform): proto.NewDRPCProvisionerClient(terraformClient),

Original file line number	Diff line number	Diff line change
`@@ -104,14 +104,20 @@ func (r RootCmd) provisionerDaemonStart() serpent.Command {`
`104`	`104`	`return err`
`105`	`105`	`}`
`106`	`106`
	`107`	`+ displayedTags := make(map[string]string, len(tags))`
	`108`	`+ for key, val := range tags {`
	`109`	`+ displayedTags[key] = val`
	`110`	`+ }`
	`111`	`+`
`107`	`112`	`if provisionerKey != "" {`
`108`	`113`	`pkDetails, err := client.GetProvisionerKey(ctx, provisionerKey)`
`109`	`114`	`if err != nil {`
`110`		`- return xerrors.Errorf("unable to get provisioner key details: %w", err)`
	`115`	`+ return xerrors.New("unable to get provisioner key details")`
`111`	`116`	`}`
`112`	`117`
	`118`	`+ displayedTags = make(map[string]string, len(pkDetails.Tags))`
`113`	`119`	`for k, v := range pkDetails.Tags {`
`114`		`- tags[k] = v`
	`120`	`+ displayedTags[k] = v`
`115`	`121`	`}`
`116`	`122`	`}`
`117`	`123`
`@@ -142,7 +148,7 @@ func (r RootCmd) provisionerDaemonStart() serpent.Command {`
`142`	`148`	`defer closeLogger()`
`143`	`149`	`}`
`144`	`150`
`145`		`- if len(tags) == 0 {`
	`151`	`+ if len(displayedTags) == 0 {`
`146`	`152`	`logger.Info(ctx, "note: untagged provisioners can only pick up jobs from untagged templates")`
`147`	`153`	`}`
`148`	`154`
`@@ -213,7 +219,7 @@ func (r RootCmd) provisionerDaemonStart() serpent.Command {`
`213`	`219`	`defer closeFunc()`
`214`	`220`	`}`
`215`	`221`
`216`		`- logger.Info(ctx, "starting provisioner daemon", slog.F("tags", tags), slog.F("name", name))`
	`222`	`+ logger.Info(ctx, "starting provisioner daemon", slog.F("tags", displayedTags), slog.F("name", name))`
`217`	`223`
`218`	`224`	`connector := provisionerd.LocalProvisioners{`
`219`	`225`	`string(database.ProvisionerTypeTerraform): proto.NewDRPCProvisionerClient(terraformClient),`