coder
diff --git a/‎coderd/provisionerdserver/provisionerdserver.go
Lines changed: 1 addition & 1 deletion b/‎coderd/provisionerdserver/provisionerdserver.go
Lines changed: 1 addition & 1 deletion
diff --git a/‎provisioner/terraform/provision.go
Lines changed: 3 additions & 3 deletions b/‎provisioner/terraform/provision.go
Lines changed: 3 additions & 3 deletions
diff --git a/‎provisioner/terraform/resources.go
Lines changed: 0 additions & 2 deletions b/‎provisioner/terraform/resources.go
Lines changed: 0 additions & 2 deletions
diff --git a/‎provisioner/terraform/timings_test.go
Lines changed: 1 addition & 1 deletion b/‎provisioner/terraform/timings_test.go
Lines changed: 1 addition & 1 deletion
diff --git a/‎provisionersdk/proto/provisioner.pb.go
Lines changed: 25 additions & 29 deletions b/‎provisionersdk/proto/provisioner.pb.go
Lines changed: 25 additions & 29 deletions
diff --git a/‎provisionersdk/proto/provisioner.proto
Lines changed: 2 additions & 3 deletions b/‎provisionersdk/proto/provisioner.proto
Lines changed: 2 additions & 3 deletions
diff --git a/‎site/e2e/provisionerGenerated.ts
Lines changed: 2 additions & 3 deletions b/‎site/e2e/provisionerGenerated.ts
Lines changed: 2 additions & 3 deletions
diff --git a/‎site/src/api/typesGenerated.ts
Lines changed: 0 additions & 1 deletion b/‎site/src/api/typesGenerated.ts
Lines changed: 0 additions & 1 deletion
@@ -2017,7 +2017,7 @@ func InsertWorkspaceResource(ctx context.Context, db database.Store, jobID uuid.
 			switch app.OpenIn {
 			case sdkproto.AppOpenIn_TAB:
 				openIn = database.WorkspaceAppOpenInTab
-			case sdkproto.AppOpenIn_WINDOW:
+			case sdkproto.AppOpenIn_SLIM_WINDOW:
 				openIn = database.WorkspaceAppOpenInWindow
 			}
 
 
@@ -78,7 +78,7 @@ func (s *server) Plan(
 
 	e := s.executor(sess.WorkDirectory, database.ProvisionerJobTimingStagePlan)
 	if err := e.checkMinVersion(ctx); err != nil {
-		return provisionersdk.PlanErrorf(err.Error())
+		return provisionersdk.PlanErrorf("%s", err.Error())
 	}
 	logTerraformEnvVars(sess)
 
@@ -168,7 +168,7 @@ func (s *server) Plan(
 		request.Metadata.GetWorkspaceTransition() == proto.WorkspaceTransition_DESTROY,
 	)
 	if err != nil {
-		return provisionersdk.PlanErrorf(err.Error())
+		return provisionersdk.PlanErrorf("%s", err.Error())
 	}
 
 	// Prepend init timings since they occur prior to plan timings.
@@ -189,7 +189,7 @@ func (s *server) Apply(
 
 	e := s.executor(sess.WorkDirectory, database.ProvisionerJobTimingStageApply)
 	if err := e.checkMinVersion(ctx); err != nil {
-		return provisionersdk.ApplyErrorf(err.Error())
+		return provisionersdk.ApplyErrorf("%s", err.Error())
 	}
 	logTerraformEnvVars(sess)
 
 
@@ -437,8 +437,6 @@ func ConvertState(ctx context.Context, modules []*tfjson.StateModule, rawGraph s
 			switch strings.ToLower(attrs.OpenIn) {
 			case "slim-window":
 				openIn = proto.AppOpenIn_SLIM_WINDOW
-			case "window":
-				openIn = proto.AppOpenIn_WINDOW
 			case "tab":
 				openIn = proto.AppOpenIn_TAB
 			}
 
@@ -28,7 +28,7 @@ func TestTimingsFromProvision(t *testing.T) {
 	// Given: a fake terraform bin that behaves as we expect it to.
 	fakeBin := filepath.Join(cwd, "testdata", "timings-aggregation/fake-terraform.sh")
 
-	t.Logf(fakeBin)
+	t.Log("%s", fakeBin)
 
 	ctx, api := setupProvisioner(t, &provisionerServeOptions{
 		binaryPath: fakeBin,
 
@@ -164,9 +164,8 @@ message Script {
 }
 
 enum AppOpenIn {
-    WINDOW = 0;
-    SLIM_WINDOW = 1;
-    TAB = 2;
+    SLIM_WINDOW = 0;
+    TAB = 1;
 }
 
 // App represents a dev-accessible application on the workspace.
Original file line number	Diff line number	Diff line change
`@@ -2017,7 +2017,7 @@ func InsertWorkspaceResource(ctx context.Context, db database.Store, jobID uuid.`
`2017`	`2017`	`switch app.OpenIn {`
`2018`	`2018`	`case sdkproto.AppOpenIn_TAB:`
`2019`	`2019`	`openIn = database.WorkspaceAppOpenInTab`
`2020`		`- case sdkproto.AppOpenIn_WINDOW:`
	`2020`	`+ case sdkproto.AppOpenIn_SLIM_WINDOW:`
`2021`	`2021`	`openIn = database.WorkspaceAppOpenInWindow`
`2022`	`2022`	`}`
`2023`	`2023`
Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ func (s *server) Plan(`
`78`	`78`
`79`	`79`	`e := s.executor(sess.WorkDirectory, database.ProvisionerJobTimingStagePlan)`
`80`	`80`	`if err := e.checkMinVersion(ctx); err != nil {`
`81`		`- return provisionersdk.PlanErrorf(err.Error())`
	`81`	`+ return provisionersdk.PlanErrorf("%s", err.Error())`
`82`	`82`	`}`
`83`	`83`	`logTerraformEnvVars(sess)`
`84`	`84`
`@@ -168,7 +168,7 @@ func (s *server) Plan(`
`168`	`168`	`request.Metadata.GetWorkspaceTransition() == proto.WorkspaceTransition_DESTROY,`
`169`	`169`	`)`
`170`	`170`	`if err != nil {`
`171`		`- return provisionersdk.PlanErrorf(err.Error())`
	`171`	`+ return provisionersdk.PlanErrorf("%s", err.Error())`
`172`	`172`	`}`
`173`	`173`
`174`	`174`	`// Prepend init timings since they occur prior to plan timings.`
`@@ -189,7 +189,7 @@ func (s *server) Apply(`
`189`	`189`
`190`	`190`	`e := s.executor(sess.WorkDirectory, database.ProvisionerJobTimingStageApply)`
`191`	`191`	`if err := e.checkMinVersion(ctx); err != nil {`
`192`		`- return provisionersdk.ApplyErrorf(err.Error())`
	`192`	`+ return provisionersdk.ApplyErrorf("%s", err.Error())`
`193`	`193`	`}`
`194`	`194`	`logTerraformEnvVars(sess)`
`195`	`195`
Original file line number	Diff line number	Diff line change
`@@ -437,8 +437,6 @@ func ConvertState(ctx context.Context, modules []*tfjson.StateModule, rawGraph s`
`437`	`437`	`switch strings.ToLower(attrs.OpenIn) {`
`438`	`438`	`case "slim-window":`
`439`	`439`	`openIn = proto.AppOpenIn_SLIM_WINDOW`
`440`		`- case "window":`
`441`		`- openIn = proto.AppOpenIn_WINDOW`
`442`	`440`	`case "tab":`
`443`	`441`	`openIn = proto.AppOpenIn_TAB`
`444`	`442`	`}`
Original file line number	Diff line number	Diff line change
`@@ -164,9 +164,8 @@ message Script {`
`164`	`164`	`}`
`165`	`165`
`166`	`166`	`enum AppOpenIn {`
`167`		`- WINDOW = 0;`
`168`		`- SLIM_WINDOW = 1;`
`169`		`- TAB = 2;`
	`167`	`+ SLIM_WINDOW = 0;`
	`168`	`+ TAB = 1;`
`170`	`169`	`}`
`171`	`170`
`172`	`171`	`// App represents a dev-accessible application on the workspace.`