Skip to content

Commit b68b46a

Browse files
committed
fix stories
1 parent 20d5672 commit b68b46a

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

site/src/pages/UsersPage/UsersPageView.stories.tsx

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { ComponentMeta, Story } from "@storybook/react"
2+
import { createPaginationRef } from "components/PaginationWidget/utils"
23
import {
3-
MockSiteRoles,
4+
MockAssignableSiteRoles,
45
MockUser,
56
MockUser2,
67
} from "../../testHelpers/renderHelpers"
@@ -9,6 +10,11 @@ import { UsersPageView, UsersPageViewProps } from "./UsersPageView"
910
export default {
1011
title: "pages/UsersPageView",
1112
component: UsersPageView,
13+
argTypes: {
14+
paginationRef: {
15+
defaultValue: createPaginationRef({ page: 1, limit: 25 })
16+
}
17+
}
1218
} as ComponentMeta<typeof UsersPageView>
1319

1420
const Template: Story<UsersPageViewProps> = (args) => (
@@ -18,8 +24,7 @@ const Template: Story<UsersPageViewProps> = (args) => (
1824
export const Admin = Template.bind({})
1925
Admin.args = {
2026
users: [MockUser, MockUser2],
21-
roles: MockSiteRoles,
22-
canCreateUser: true,
27+
roles: MockAssignableSiteRoles,
2328
canEditUsers: true,
2429
}
2530

@@ -32,7 +37,7 @@ SmallViewport.parameters = {
3237
}
3338

3439
export const Member = Template.bind({})
35-
Member.args = { ...Admin.args, canCreateUser: false, canEditUsers: false }
40+
Member.args = { ...Admin.args, canEditUsers: false }
3641

3742
export const Empty = Template.bind({})
3843
Empty.args = { ...Admin.args, users: [] }

site/src/testHelpers/entities.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,6 @@ export const MockAuditorRole: TypesGen.Role = {
4848
display_name: "Auditor",
4949
}
5050

51-
export const MockSiteRoles = [MockUserAdminRole, MockAuditorRole]
52-
5351
// assignableRole takes a role and a boolean. The boolean implies if the
5452
// actor can assign (add/remove) the role from other users.
5553
export function assignableRole(
@@ -62,6 +60,9 @@ export function assignableRole(
6260
}
6361
}
6462

63+
export const MockSiteRoles = [MockUserAdminRole, MockAuditorRole]
64+
export const MockAssignableSiteRoles = [assignableRole(MockUserAdminRole, true), assignableRole(MockAuditorRole, true)]
65+
6566
export const MockMemberPermissions = {
6667
viewAuditLog: false,
6768
}

0 commit comments

Comments
 (0)