rename

mafredri · mafredri · commit b6e809c5ff6f · 2023-12-19T12:45:25.000Z
diff --git a/cli/open.go b/cli/open.go
@@ -35,7 +35,7 @@ const vscodeDesktopName = "VS Code Desktop"
 func (r *RootCmd) openVSCode() *clibase.Cmd {
 	var (
 		generateToken bool
-		testNoOpen    bool
+		testOpenError bool
 	)
 
 	client := new(codersdk.Client)
@@ -171,10 +171,10 @@ func (r *RootCmd) openVSCode() *clibase.Cmd {
 			}
 			_, _ = fmt.Fprintf(inv.Stderr, "Opening %s in %s\n", openingPath, vscodeDesktopName)
 
-			if !testNoOpen {
+			if !testOpenError {
 				err = open.Run(u.String())
 			} else {
-				err = xerrors.New("test.no-open")
+				err = xerrors.New("test.open-error")
 			}
 			if err != nil {
 				if !generateToken {
@@ -204,9 +204,9 @@ func (r *RootCmd) openVSCode() *clibase.Cmd {
 			Value: clibase.BoolOf(&generateToken),
 		},
 		{
-			Flag:        "test.no-open",
+			Flag:        "test.open-error",
 			Description: "Don't run the open command.",
-			Value:       clibase.BoolOf(&testNoOpen),
+			Value:       clibase.BoolOf(&testOpenError),
 			Hidden:      true, // This is for testing!
 		},
 	}
diff --git a/cli/open_test.go b/cli/open_test.go
@@ -57,31 +57,31 @@ func TestOpen(t *testing.T) {
 		},
 		{
 			name:      "nonexistent workspace",
-			args:      []string{"--test.no-open", workspace.Name + "bad"},
+			args:      []string{"--test.open-error", workspace.Name + "bad"},
 			wantError: true,
 		},
 		{
 			name:    "ok",
-			args:    []string{"--test.no-open", workspace.Name},
+			args:    []string{"--test.open-error", workspace.Name},
 			wantDir: agentDir,
 		},
 		{
 			name:      "relative path error",
-			args:      []string{"--test.no-open", workspace.Name, "my/relative/path"},
+			args:      []string{"--test.open-error", workspace.Name, "my/relative/path"},
 			wantError: true,
 		},
 		{
 			name:    "ok with abs path",
-			args:    []string{"--test.no-open", workspace.Name, agentDir},
+			args:    []string{"--test.open-error", workspace.Name, agentDir},
 			wantDir: agentDir,
 		},
 		{
 			name:      "ok with token",
-			args:      []string{"--test.no-open", workspace.Name, "--generate-token"},
+			args:      []string{"--test.open-error", workspace.Name, "--generate-token"},
 			wantDir:   agentDir,
 			wantToken: true,
 		},
-		// Inside workspace, does not require --test.no-open.
+		// Inside workspace, does not require --test.open-error.
 		{
 			name:    "ok inside workspace",
 			env:     insideWorkspaceEnv,
