fixup! fix(enterprise/coderd): skip org membership check for prebuilds user on group patch

johnstcn · johnstcn · commit b7fff241d925 · 2025-06-11T17:46:24.000+01:00
diff --git a/enterprise/coderd/groups.go b/enterprise/coderd/groups.go
@@ -172,9 +172,10 @@ func (api *API) patchGroup(rw http.ResponseWriter, r *http.Request) {
 			})
 			return
 		}
-		// Skip membership checks for the prebuilds user.
+		// Skip membership checks for the prebuilds user. There is a valid use case
+		// for adding the prebuilds user to a single group: in order to set a quota
+		// allowance specifically for prebuilds.
 		if id == prebuilds.SystemUserID.String() {
-			api.Logger.Debug(ctx, "Skipping membership check for prebuilds user")
 			continue
 		}
 		_, err := database.ExpectOne(api.Database.OrganizationMembers(ctx, database.OrganizationMembersParams{

Original file line number	Diff line number	Diff line change
`@@ -172,9 +172,10 @@ func (api API) patchGroup(rw http.ResponseWriter, r http.Request) {`
`172`	`172`	`})`
`173`	`173`	`return`
`174`	`174`	`}`
`175`		`- // Skip membership checks for the prebuilds user.`
	`175`	`+ // Skip membership checks for the prebuilds user. There is a valid use case`
	`176`	`+ // for adding the prebuilds user to a single group: in order to set a quota`
	`177`	`+ // allowance specifically for prebuilds.`
`176`	`178`	`if id == prebuilds.SystemUserID.String() {`
`177`		`- api.Logger.Debug(ctx, "Skipping membership check for prebuilds user")`
`178`	`179`	`continue`
`179`	`180`	`}`
`180`	`181`	`_, err := database.ExpectOne(api.Database.OrganizationMembers(ctx, database.OrganizationMembersParams{`