remove unnecessary interface and export struct

johnstcn · johnstcn · commit b9b7a5a0a237 · 2022-04-04T11:14:13.000Z
diff --git a/coderd/crontab/crontab.go b/coderd/crontab/crontab.go
@@ -11,7 +11,7 @@ const parserFormat = cron.Minute | cron.Hour | cron.Dow
 
 var defaultParser = cron.NewParser(parserFormat)
 
-// WeeklySchedule represents a weekly cron schedule serializable to and from a string.
+// CronSchedule represents a weekly cron schedule serializable to and from a string.
 //
 // Example Usage:
 //  local_sched, _ := cron.Parse("59 23 *")
@@ -20,31 +20,25 @@ var defaultParser = cron.NewParser(parserFormat)
 //  us_sched, _ := cron.Parse("CRON_TZ=US/Central 30 9 1-5")
 //  fmt.Println(sched.Next(time.Now()).Format(time.RFC3339))
 //  // Output: 2022-04-04T14:30:00Z
-type WeeklySchedule interface {
-	String() string
-	Next(time.Time) time.Time
-}
 
-// cronSchedule is a thin wrapper for cron.SpecSchedule that implements Stringer.
-type cronSchedule struct {
+// WeeklySchedule is a thin wrapper for cron.SpecSchedule that implements Stringer.
+type WeeklySchedule struct {
 	sched *cron.SpecSchedule
 	// XXX: there isn't any nice way for robfig/cron to serialize
 	spec string
 }
 
-var _ WeeklySchedule = (*cronSchedule)(nil)
-
 // String serializes the schedule to its original human-friendly format.
-func (s cronSchedule) String() string {
+func (s WeeklySchedule) String() string {
 	return s.spec
 }
 
 // Next returns the next time in the schedule relative to t.
-func (s cronSchedule) Next(t time.Time) time.Time {
+func (s WeeklySchedule) Next(t time.Time) time.Time {
 	return s.sched.Next(t)
 }
 
-func Parse(spec string) (*cronSchedule, error) {
+func Parse(spec string) (*WeeklySchedule, error) {
 	specSched, err := defaultParser.Parse(spec)
 	if err != nil {
 		return nil, xerrors.Errorf("parse schedule: %w", err)
@@ -55,10 +49,9 @@ func Parse(spec string) (*cronSchedule, error) {
 		return nil, xerrors.Errorf("expected *cron.SpecSchedule but got %T", specSched)
 	}
 
-	cronSched := &cronSchedule{
+	cronSched := &WeeklySchedule{
 		sched: schedule,
 		spec:  spec,
 	}
 	return cronSched, nil
-
 }
diff --git a/coderd/crontab/crontab_test.go b/coderd/crontab/crontab_test.go
@@ -4,8 +4,9 @@ import (
 	"testing"
 	"time"
 
-	"github.com/coder/coder/coderd/crontab"
 	"github.com/stretchr/testify/require"
+
+	"github.com/coder/coder/coderd/crontab"
 )
 
 func Test_Parse(t *testing.T) {

Original file line number	Diff line number	Diff line change
`@@ -4,8 +4,9 @@ import (`
`4`	`4`	`"testing"`
`5`	`5`	`"time"`
`6`	`6`
`7`		`- "github.com/coder/coder/coderd/crontab"`
`8`	`7`	`"github.com/stretchr/testify/require"`
	`8`	`+`
	`9`	`+ "github.com/coder/coder/coderd/crontab"`
`9`	`10`	`)`
`10`	`11`
`11`	`12`	`func Test_Parse(t *testing.T) {`