Skip to content

Commit bb699fb

Browse files
committed
Merge branch 'main' into dean/proxy-derp-map
2 parents 0e6d39a + 8c4b7c0 commit bb699fb

File tree

40 files changed

+5053
-3806
lines changed

40 files changed

+5053
-3806
lines changed

Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,7 @@ lint/helm:
431431
gen: \
432432
coderd/database/dump.sql \
433433
coderd/database/querier.go \
434-
coderd/database/dbmock/store.go \
434+
coderd/database/dbmock/dbmock.go \
435435
provisionersdk/proto/provisioner.pb.go \
436436
provisionerd/proto/provisionerd.pb.go \
437437
site/src/api/typesGenerated.ts \
@@ -453,7 +453,7 @@ gen/mark-fresh:
453453
files="\
454454
coderd/database/dump.sql \
455455
coderd/database/querier.go \
456-
coderd/database/dbmock/store.go \
456+
coderd/database/dbmock/dbmock.go \
457457
provisionersdk/proto/provisioner.pb.go \
458458
provisionerd/proto/provisionerd.pb.go \
459459
site/src/api/typesGenerated.ts \
@@ -490,7 +490,7 @@ coderd/database/querier.go: coderd/database/sqlc.yaml coderd/database/dump.sql $
490490
./coderd/database/generate.sh
491491

492492

493-
coderd/database/dbmock/store.go: coderd/database/db.go coderd/database/querier.go
493+
coderd/database/dbmock/dbmock.go: coderd/database/db.go coderd/database/querier.go
494494
go generate ./coderd/database/dbmock/
495495

496496
provisionersdk/proto/provisioner.pb.go: provisionersdk/proto/provisioner.proto

agent/agentssh/agentssh.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -648,9 +648,11 @@ func (s *Server) trackSession(ss ssh.Session, add bool) (ok bool) {
648648
// Server closed.
649649
return false
650650
}
651+
s.wg.Add(1)
651652
s.sessions[ss] = struct{}{}
652653
return true
653654
}
655+
s.wg.Done()
654656
delete(s.sessions, ss)
655657
return true
656658
}

coderd/coderd.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ import (
4646
"github.com/coder/coder/coderd/database"
4747
"github.com/coder/coder/coderd/database/dbauthz"
4848
"github.com/coder/coder/coderd/database/dbmetrics"
49-
"github.com/coder/coder/coderd/database/dbtype"
5049
"github.com/coder/coder/coderd/gitauth"
5150
"github.com/coder/coder/coderd/gitsshkey"
5251
"github.com/coder/coder/coderd/healthcheck"
@@ -949,7 +948,7 @@ func (api *API) CreateInMemoryProvisionerDaemon(ctx context.Context, debounce ti
949948
CreatedAt: database.Now(),
950949
Name: name,
951950
Provisioners: []database.ProvisionerType{database.ProvisionerTypeEcho, database.ProvisionerTypeTerraform},
952-
Tags: dbtype.StringMap{
951+
Tags: database.StringMap{
953952
provisionerdserver.TagScope: provisionerdserver.ScopeOrganization,
954953
},
955954
})

coderd/coderdtest/coderdtest.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,8 @@ func newWithCloser(t testing.TB, options *Options) (*codersdk.Client, io.Closer)
169169
}
170170

171171
func NewOptions(t testing.TB, options *Options) (func(http.Handler), context.CancelFunc, *url.URL, *coderd.Options) {
172+
t.Helper()
173+
172174
if options == nil {
173175
options = &Options{}
174176
}
@@ -402,6 +404,8 @@ func NewWithAPI(t testing.TB, options *Options) (*codersdk.Client, io.Closer, *c
402404
// well with coderd testing. It registers the "echo" provisioner for
403405
// quick testing.
404406
func NewProvisionerDaemon(t testing.TB, coderAPI *coderd.API) io.Closer {
407+
t.Helper()
408+
405409
echoClient, echoServer := provisionersdk.MemTransportPipe()
406410
ctx, cancelFunc := context.WithCancel(context.Background())
407411
t.Cleanup(func() {

coderd/csp.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ func (api *API) logReportCSPViolations(rw http.ResponseWriter, r *http.Request)
3939
return
4040
}
4141

42-
fields := make([]slog.Field, 0, len(v.Report))
42+
fields := make([]any, 0, len(v.Report))
4343
for k, v := range v.Report {
4444
fields = append(fields, slog.F(k, v))
4545
}

0 commit comments

Comments
 (0)