test: add test cases for domain concealment in auth error messages

ericpaulsen · ericpaulsen · commit bbdd048969bb · 2025-03-27T12:51:25.000Z
- Verifies the error message no longer shows domain list - Adds tests for both invalid domain and malformed email cases - Includes test for successful login with allowed domain - Fixes response body closing in test
diff --git a/coderd/domain_error_test.go b/coderd/domain_error_test.go
@@ -111,7 +111,8 @@ func TestOIDCDomainErrorMessage(t *testing.T) {
 		}
 
 		// Attempt login and expect success
-		client, _ := fake.Login(t, server, claims)
+		client, resp := fake.Login(t, server, claims)
+		defer resp.Body.Close()
 
 		// Verify the user was created correctly
 		user, err := client.User(context.Background(), "me")

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,8 @@ func TestOIDCDomainErrorMessage(t *testing.T) {`
`111`	`111`	`}`
`112`	`112`
`113`	`113`	`// Attempt login and expect success`
`114`		`- client, _ := fake.Login(t, server, claims)`
	`114`	`+ client, resp := fake.Login(t, server, claims)`
	`115`	`+ defer resp.Body.Close()`
`115`	`116`
`116`	`117`	`// Verify the user was created correctly`
`117`	`118`	`user, err := client.User(context.Background(), "me")`