fix(coderd): prevent oidc refresh being ignored

coryb · coryb · commit bf4737d8ce5c · 2023-08-23T16:51:36.000-07:00
A recent refactor (#8950) caused the oidc refresh results to be ignored due to the lexical scoping of the `link` variable.
diff --git a/coderd/httpmw/apikey.go b/coderd/httpmw/apikey.go
@@ -241,8 +241,9 @@ func ExtractAPIKey(rw http.ResponseWriter, r *http.Request, cfg ExtractAPIKeyCon
 		changed = false
 	)
 	if key.LoginType == database.LoginTypeGithub || key.LoginType == database.LoginTypeOIDC {
+		var err error
 		//nolint:gocritic // System needs to fetch UserLink to check if it's valid.
-		link, err := cfg.DB.GetUserLinkByUserIDLoginType(dbauthz.AsSystemRestricted(ctx), database.GetUserLinkByUserIDLoginTypeParams{
+		link, err = cfg.DB.GetUserLinkByUserIDLoginType(dbauthz.AsSystemRestricted(ctx), database.GetUserLinkByUserIDLoginTypeParams{
 			UserID:    key.UserID,
 			LoginType: key.LoginType,
 		})
