Only show job status if completed

kylecarbs · kylecarbs · commit bff96b692b88 · 2022-02-11T03:53:19.000Z
diff --git a/cli/projectcreate.go b/cli/projectcreate.go
@@ -131,12 +131,13 @@ func doProjectLoop(cmd *cobra.Command, client *codersdk.Client, organization cod
 	if err != nil {
 		return nil, err
 	}
+	logBuffer := make([]coderd.ProvisionerJobLog, 0, 64)
 	for {
-		_, ok := <-logs
+		log, ok := <-logs
 		if !ok {
 			break
 		}
-		// _, _ = fmt.Fprintf(cmd.OutOrStdout(), "%s %s\n", color.HiGreenString("[tf]"), log.Output)
+		logBuffer = append(logBuffer, log)
 	}
 
 	job, err = client.ProvisionerJob(cmd.Context(), organization.Name, job.ID)
@@ -184,6 +185,10 @@ func doProjectLoop(cmd *cobra.Command, client *codersdk.Client, organization cod
 	}
 
 	if job.Status != coderd.ProvisionerJobStatusSucceeded {
+		for _, log := range logBuffer {
+			_, _ = fmt.Fprintf(cmd.OutOrStdout(), "%s %s\n", color.HiGreenString("[tf]"), log.Output)
+		}
+
 		return nil, xerrors.New(job.Error)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -131,12 +131,13 @@ func doProjectLoop(cmd cobra.Command, client codersdk.Client, organization cod`
`131`	`131`	`if err != nil {`
`132`	`132`	`return nil, err`
`133`	`133`	`}`
	`134`	`+ logBuffer := make([]coderd.ProvisionerJobLog, 0, 64)`
`134`	`135`	`for {`
`135`		`- _, ok := <-logs`
	`136`	`+ log, ok := <-logs`
`136`	`137`	`if !ok {`
`137`	`138`	`break`
`138`	`139`	`}`
`139`		`- // _, _ = fmt.Fprintf(cmd.OutOrStdout(), "%s %s\n", color.HiGreenString("[tf]"), log.Output)`
	`140`	`+ logBuffer = append(logBuffer, log)`
`140`	`141`	`}`
`141`	`142`
`142`	`143`	`job, err = client.ProvisionerJob(cmd.Context(), organization.Name, job.ID)`
`@@ -184,6 +185,10 @@ func doProjectLoop(cmd cobra.Command, client codersdk.Client, organization cod`
`184`	`185`	`}`
`185`	`186`
`186`	`187`	`if job.Status != coderd.ProvisionerJobStatusSucceeded {`
	`188`	`+ for _, log := range logBuffer {`
	`189`	`+ _, _ = fmt.Fprintf(cmd.OutOrStdout(), "%s %s\n", color.HiGreenString("[tf]"), log.Output)`
	`190`	`+ }`
	`191`	`+`
`187`	`192`	`return nil, xerrors.New(job.Error)`
`188`	`193`	`}`
`189`	`194`