fix: copy app ID in healthcheck (#12087)

deansheather · coadler · commit c0aeb2fc2ef9 · 2024-02-12T05:30:34.000Z
(cherry picked from commit 429144d)
diff --git a/codersdk/agentsdk/convert.go b/codersdk/agentsdk/convert.go
@@ -286,8 +286,11 @@ func ProtoFromAppHealthsRequest(req PostAppHealthsRequest) (*proto.BatchUpdateAp
 		if !ok {
 			return nil, xerrors.Errorf("unknown app health: %s", h)
 		}
+
+		var idCopy uuid.UUID
+		copy(idCopy[:], id[:])
 		pReq.Updates = append(pReq.Updates, &proto.BatchUpdateAppHealthRequest_HealthUpdate{
-			Id:     id[:],
+			Id:     idCopy[:],
 			Health: proto.AppHealth(hp),
 		})
 	}

Original file line number	Diff line number	Diff line change
`@@ -286,8 +286,11 @@ func ProtoFromAppHealthsRequest(req PostAppHealthsRequest) (*proto.BatchUpdateAp`
`286`	`286`	`if !ok {`
`287`	`287`	`return nil, xerrors.Errorf("unknown app health: %s", h)`
`288`	`288`	`}`
	`289`	`+`
	`290`	`+ var idCopy uuid.UUID`
	`291`	`+ copy(idCopy[:], id[:])`
`289`	`292`	`pReq.Updates = append(pReq.Updates, &proto.BatchUpdateAppHealthRequest_HealthUpdate{`
`290`		`- Id: id[:],`
	`293`	`+ Id: idCopy[:],`
`291`	`294`	`Health: proto.AppHealth(hp),`
`292`	`295`	`})`
`293`	`296`	`}`