rename to outdated

Emyrk · Emyrk · commit c19df1eecf77 · 2024-01-22T14:57:10.000-06:00
diff --git a/coderd/searchquery/search.go b/coderd/searchquery/search.go
@@ -112,10 +112,12 @@ func Workspaces(query string, page codersdk.Pagination, agentInactiveDisconnectT
 	filter.LastUsedAfter = parser.Time3339Nano(values, time.Time{}, "last_used_after")
 	filter.LastUsedBefore = parser.Time3339Nano(values, time.Time{}, "last_used_before")
 	filter.UsingActive = sql.NullBool{
+		// Invert the value of the query parameter to get the correct value.
 		// UsingActive returns if the workspace is on the latest template active version.
-		// This means the workspace is "up to date".
-		Bool:  parser.Boolean(values, false, "updated"),
-		Valid: values.Has("updated"),
+		Bool: !parser.Boolean(values, true, "outdated"),
+		// Only include this search term if it was provided. Otherwise default to omitting it
+		// which will return all workspaces.
+		Valid: values.Has("outdated"),
 	}
 
 	parser.ErrorExcessParams(values)
diff --git a/coderd/searchquery/search_test.go b/coderd/searchquery/search_test.go
@@ -117,17 +117,26 @@ func TestSearchWorkspace(t *testing.T) {
 				OwnerUsername: "foo",
 			},
 		},
+		{
+			Name:  "Outdated",
+			Query: `outdated:true`,
+			Expected: database.GetWorkspacesParams{
+				UsingActive: sql.NullBool{
+					Bool:  false,
+					Valid: true,
+				},
+			},
+		},
 		{
 			Name:  "Updated",
-			Query: `updated:true`,
+			Query: `outdated:false`,
 			Expected: database.GetWorkspacesParams{
 				UsingActive: sql.NullBool{
 					Bool:  true,
 					Valid: true,
 				},
 			},
 		},
-
 		// Failures
 		{
 			Name:                  "NoPrefix",
diff --git a/site/src/pages/WorkspacesPage/filter/filter.tsx b/site/src/pages/WorkspacesPage/filter/filter.tsx
@@ -22,7 +22,7 @@ export const workspaceFilterQuery = {
   running: "status:running",
   failed: "status:failed",
   dormant: "dormant:true",
-  outdated: "updated:false",
+  outdated: "outdated:true",
 };
 
 type FilterPreset = {
