add test for push notifications being enabled

johnstcn · johnstcn · commit c1d5a007e410 · 2025-03-25T21:59:23.000Z
diff --git a/coderd/notifications_test.go b/coderd/notifications_test.go
@@ -6,6 +6,7 @@ import (
 	"slices"
 	"testing"
 
+	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 
 	"github.com/coder/serpent"
@@ -14,6 +15,7 @@ import (
 	"github.com/coder/coder/v2/coderd/database"
 	"github.com/coder/coder/v2/coderd/notifications"
 	"github.com/coder/coder/v2/coderd/notifications/notificationstest"
+	"github.com/coder/coder/v2/coderd/notifications/push"
 	"github.com/coder/coder/v2/codersdk"
 	"github.com/coder/coder/v2/testutil"
 )
@@ -388,6 +390,23 @@ const (
 func TestPushNotificationSubscription(t *testing.T) {
 	t.Parallel()
 
+	t.Run("Disabled", func(t *testing.T) {
+		t.Parallel()
+
+		client := coderdtest.New(t, &coderdtest.Options{
+			PushNotifier: &push.NoopNotifier{
+				Msg: assert.AnError.Error(),
+			},
+		})
+
+		ctx := testutil.Context(t, testutil.WaitShort)
+
+		owner := coderdtest.CreateFirstUser(t, client)
+		memberClient, _ := coderdtest.CreateAnotherUser(t, client, owner.OrganizationID)
+		err := memberClient.TestPushNotification(ctx)
+		require.EqualError(t, err, assert.AnError.Error(), "test push notification should fail")
+	})
+
 	t.Run("CRUD", func(t *testing.T) {
 		t.Parallel()
 
