Skip to content

Commit c274b27

Browse files
committed
add some minor comments
1 parent e8ad3d4 commit c274b27

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

cli/templatepull_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import (
1010
"github.com/coder/coder/coderd/coderdtest"
1111
"github.com/coder/coder/provisioner/echo"
1212
"github.com/coder/coder/provisionersdk/proto"
13-
"github.com/coder/coder/pty/ptytest"
1413
)
1514

1615
func TestTemplatePull(t *testing.T) {
@@ -19,6 +18,7 @@ func TestTemplatePull(t *testing.T) {
1918
client := coderdtest.New(t, &coderdtest.Options{IncludeProvisionerD: true})
2019
user := coderdtest.CreateFirstUser(t, client)
2120

21+
// Create an initial template bundle.
2222
templateSource := &echo.Responses{
2323
Parse: []*proto.Parse_Response{
2424
{
@@ -36,6 +36,8 @@ func TestTemplatePull(t *testing.T) {
3636
Provision: echo.ProvisionComplete,
3737
}
3838

39+
// Create an updated template bundle. This will be used to ensure
40+
// that templates are correctly returned in order from latest to oldest.
3941
templateSource2 := &echo.Responses{
4042
Parse: []*proto.Parse_Response{
4143
{
@@ -60,20 +62,18 @@ func TestTemplatePull(t *testing.T) {
6062
_ = coderdtest.AwaitTemplateVersionJob(t, client, version1.ID)
6163
template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version1.ID)
6264

65+
// Update the template version so that we can assert that templates
66+
// are being sorted correctly.
6367
_ = coderdtest.UpdateTemplateVersion(t, client, user.OrganizationID, templateSource2, template.ID)
6468

6569
cmd, root := clitest.New(t, "templates", "pull", template.Name)
6670
clitest.SetupConfig(t, client, root)
6771

6872
buf := &bytes.Buffer{}
69-
pty := ptytest.New(t)
7073
cmd.SetOut(buf)
7174

7275
err = cmd.Execute()
7376
require.NoError(t, err)
7477

75-
err = pty.Close()
76-
require.NoError(t, err)
77-
7878
require.True(t, bytes.Equal(expected, buf.Bytes()), "Bytes differ")
7979
}

0 commit comments

Comments
 (0)