Skip to content

Commit c30607e

Browse files
committed
linting
1 parent 1c9df09 commit c30607e

File tree

1 file changed

+15
-6
lines changed

1 file changed

+15
-6
lines changed

coderd/provisionerdserver/upload_file_test.go

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ func TestUploadFileLargeModuleFiles(t *testing.T) {
4141

4242
for _, size := range testSizes {
4343
t.Run(fmt.Sprintf("size_%d_bytes", size), func(t *testing.T) {
44+
t.Parallel()
45+
4446
// Generate test module files data
4547
moduleData := make([]byte, size)
4648
_, err := crand.Read(moduleData)
@@ -82,6 +84,7 @@ func TestUploadFileLargeModuleFiles(t *testing.T) {
8284
func TestUploadFileErrorScenarios(t *testing.T) {
8385
t.Parallel()
8486

87+
//nolint:dogsled
8588
server, _, _, _ := setup(t, false, &overrides{
8689
externalAuthConfigs: []*externalauth.Config{{}},
8790
})
@@ -92,9 +95,10 @@ func TestUploadFileErrorScenarios(t *testing.T) {
9295
require.NoError(t, err)
9396

9497
upload, chunks := sdkproto.BytesToDataUpload(sdkproto.DataUploadType_UPLOAD_TYPE_MODULE_FILES, moduleData)
95-
var _ = upload
9698

9799
t.Run("chunk_before_upload", func(t *testing.T) {
100+
t.Parallel()
101+
98102
stream := newMockUploadStream(nil, chunks[0])
99103

100104
err := server.UploadFile(stream)
@@ -103,6 +107,8 @@ func TestUploadFileErrorScenarios(t *testing.T) {
103107
})
104108

105109
t.Run("duplicate_upload", func(t *testing.T) {
110+
t.Parallel()
111+
106112
stream := &mockUploadStream{
107113
done: make(chan struct{}),
108114
messages: make(chan *proto.UploadFileRequest, 2),
@@ -125,6 +131,9 @@ func TestUploadFileErrorScenarios(t *testing.T) {
125131
})
126132

127133
t.Run("unsupported_upload_type", func(t *testing.T) {
134+
t.Parallel()
135+
136+
//nolint:govet // Ignore lock copy
128137
cpy := *upload
129138
cpy.UploadType = sdkproto.DataUploadType_UPLOAD_TYPE_UNKNOWN // Set to an unsupported type
130139
stream := newMockUploadStream(&cpy, chunks...)
@@ -152,15 +161,15 @@ func (m mockUploadStream) Recv() (*proto.UploadFileRequest, error) {
152161
}
153162
return msg, nil
154163
}
155-
func (m *mockUploadStream) Context() context.Context { panic(errUnimplemented) }
156-
func (m *mockUploadStream) MsgSend(msg drpc.Message, enc drpc.Encoding) error {
164+
func (*mockUploadStream) Context() context.Context { panic(errUnimplemented) }
165+
func (*mockUploadStream) MsgSend(msg drpc.Message, enc drpc.Encoding) error {
157166
panic(errUnimplemented)
158167
}
159-
func (m *mockUploadStream) MsgRecv(msg drpc.Message, enc drpc.Encoding) error {
168+
func (*mockUploadStream) MsgRecv(msg drpc.Message, enc drpc.Encoding) error {
160169
panic(errUnimplemented)
161170
}
162-
func (m *mockUploadStream) CloseSend() error { panic(errUnimplemented) }
163-
func (m *mockUploadStream) Close() error { panic(errUnimplemented) }
171+
func (*mockUploadStream) CloseSend() error { panic(errUnimplemented) }
172+
func (*mockUploadStream) Close() error { panic(errUnimplemented) }
164173
func (m *mockUploadStream) isDone() bool {
165174
select {
166175
case <-m.done:

0 commit comments

Comments
 (0)