fix(coderd/unhanger): de-duplicate logs (#8686)

ammario · web-flow · commit c3b8898f0af6 · 2023-07-24T14:28:09.000+10:00
The final warning just repeated previous lines.
diff --git a/coderd/unhanger/detector.go b/coderd/unhanger/detector.go
@@ -140,9 +140,6 @@ func (d *Detector) Start() {
 				if stats.Error != nil && !xerrors.As(stats.Error, &acquireLockError{}) {
 					d.log.Warn(d.ctx, "error running workspace build hang detector once", slog.Error(stats.Error))
 				}
-				if len(stats.TerminatedJobIDs) != 0 {
-					d.log.Warn(d.ctx, "detected (and terminated) hung provisioner jobs", slog.F("job_ids", stats.TerminatedJobIDs))
-				}
 				if d.stats != nil {
 					select {
 					case <-d.ctx.Done():
@@ -251,7 +248,10 @@ func unhangJob(ctx context.Context, log slog.Logger, db database.Store, pub pubs
 			}
 		}
 
-		log.Info(ctx, "detected hung (>5m) provisioner job, forcefully terminating")
+		log.Warn(
+			ctx, "detected hung provisioner job, forcefully terminating",
+			"threshold", HungJobDuration,
+		)
 
 		// First, get the latest logs from the build so we can make sure
 		// our messages are in the latest stage.

Original file line number	Diff line number	Diff line change
`@@ -140,9 +140,6 @@ func (d *Detector) Start() {`
`140`	`140`	`if stats.Error != nil && !xerrors.As(stats.Error, &acquireLockError{}) {`
`141`	`141`	`d.log.Warn(d.ctx, "error running workspace build hang detector once", slog.Error(stats.Error))`
`142`	`142`	`}`
`143`		`- if len(stats.TerminatedJobIDs) != 0 {`
`144`		`- d.log.Warn(d.ctx, "detected (and terminated) hung provisioner jobs", slog.F("job_ids", stats.TerminatedJobIDs))`
`145`		`- }`
`146`	`143`	`if d.stats != nil {`
`147`	`144`	`select {`
`148`	`145`	`case <-d.ctx.Done():`
`@@ -251,7 +248,10 @@ func unhangJob(ctx context.Context, log slog.Logger, db database.Store, pub pubs`
`251`	`248`	`}`
`252`	`249`	`}`
`253`	`250`
`254`		`- log.Info(ctx, "detected hung (>5m) provisioner job, forcefully terminating")`
	`251`	`+ log.Warn(`
	`252`	`+ ctx, "detected hung provisioner job, forcefully terminating",`
	`253`	`+ "threshold", HungJobDuration,`
	`254`	`+ )`
`255`	`255`
`256`	`256`	`// First, get the latest logs from the build so we can make sure`
`257`	`257`	`// our messages are in the latest stage.`