Given-When-Then

mtojek · mtojek · commit c4c434e3a052 · 2023-10-12T13:48:52.000+02:00
diff --git a/enterprise/coderd/license/metricscollector_test.go b/enterprise/coderd/license/metricscollector_test.go
@@ -35,9 +35,12 @@ func TestCollectLicenseMetrics(t *testing.T) {
 		},
 	})
 
-	// When
 	registry.Register(sut)
 
+	// When
+	metrics, err := registry.Gather()
+	require.NoError(t, err)
+
 	// Then
 	goldenFile, err := os.ReadFile("testdata/license-metrics.json")
 	require.NoError(t, err)
@@ -46,10 +49,6 @@ func TestCollectLicenseMetrics(t *testing.T) {
 	require.NoError(t, err)
 
 	collected := map[string]int{}
-
-	metrics, err := registry.Gather()
-	require.NoError(t, err)
-
 	for _, metric := range metrics {
 		switch metric.GetName() {
 		case "coderd_license_active_users", "coderd_license_limit_users", "coderd_license_user_limit_enabled":
@@ -60,6 +59,5 @@ func TestCollectLicenseMetrics(t *testing.T) {
 			require.FailNowf(t, "unexpected metric collected", "metric: %s", metric.GetName())
 		}
 	}
-
 	require.EqualValues(t, golden, collected)
 }
