Begin writing unit test for external proxy

Emyrk · Emyrk · commit c5225ae80230 · 2023-04-06T16:58:50.000-05:00
diff --git a/enterprise/wsproxy/proxy.go b/enterprise/wsproxy/proxy.go
@@ -55,6 +55,8 @@ type Options struct {
 
 	APIRateLimit     int
 	SecureAuthCookie bool
+
+	ProxySessionToken string
 }
 
 // Server is an external workspace proxy server. This server can communicate
@@ -97,7 +99,7 @@ func New(opts *Options) (*Server, error) {
 	//		Ideally we reuse the same client as the cli, but this can be changed.
 	//		If the auth fails, we need some logic to retry and make sure this client
 	//		is always authenticated and usable.
-	err := client.SetSessionToken("fake-token")
+	err := client.SetSessionToken(opts.ProxySessionToken)
 	if err != nil {
 		return nil, xerrors.Errorf("set client token: %w", err)
 	}
diff --git a/enterprise/wsproxy/proxy_test.go b/enterprise/wsproxy/proxy_test.go
@@ -0,0 +1,107 @@
+package wsproxy_test
+
+import (
+	"context"
+	"net"
+	"testing"
+
+	"github.com/coder/coder/coderd/httpapi"
+	"github.com/coder/coder/enterprise/wsproxy"
+
+	"github.com/moby/moby/pkg/namesgenerator"
+	"github.com/stretchr/testify/require"
+
+	"github.com/coder/coder/enterprise/coderd/license"
+
+	"github.com/coder/coder/codersdk"
+
+	"github.com/coder/coder/enterprise/coderd/coderdenttest"
+
+	"github.com/coder/coder/cli/clibase"
+	"github.com/coder/coder/coderd/coderdtest"
+	"github.com/coder/coder/coderd/httpmw"
+	"github.com/coder/coder/coderd/workspaceapps/apptest"
+)
+
+func TestExternalProxyWorkspaceApps(t *testing.T) {
+	t.Parallel()
+
+	apptest.Run(t, func(t *testing.T, opts *apptest.DeploymentOptions) *apptest.Deployment {
+		deploymentValues := coderdtest.DeploymentValues(t)
+		deploymentValues.DisablePathApps = clibase.Bool(opts.DisablePathApps)
+		deploymentValues.Dangerous.AllowPathAppSharing = clibase.Bool(opts.DangerousAllowPathAppSharing)
+		deploymentValues.Dangerous.AllowPathAppSiteOwnerAccess = clibase.Bool(opts.DangerousAllowPathAppSiteOwnerAccess)
+		deploymentValues.Experiments = []string{
+			string(codersdk.ExperimentMoons),
+			"*",
+		}
+
+		client, _, api := coderdenttest.NewWithAPI(t, &coderdenttest.Options{
+			Options: &coderdtest.Options{
+				DeploymentValues: deploymentValues,
+				// TODO: @emyrk Should we give a hostname here too?
+				AppHostname:              "",
+				IncludeProvisionerDaemon: true,
+				RealIPConfig: &httpmw.RealIPConfig{
+					TrustedOrigins: []*net.IPNet{{
+						IP:   net.ParseIP("127.0.0.1"),
+						Mask: net.CIDRMask(8, 32),
+					}},
+					TrustedHeaders: []string{
+						"CF-Connecting-IP",
+					},
+				},
+			},
+		})
+
+		user := coderdtest.CreateFirstUser(t, client)
+		_ = coderdenttest.AddLicense(t, client, coderdenttest.LicenseOptions{
+			Features: license.Features{
+				codersdk.FeatureWorkspaceProxy: 1,
+			},
+		})
+
+		// Create the external proxy
+		// TODO: @emyrk this code will probably change as we create a better
+		// 		method of creating external proxies.
+		ctx := context.Background()
+		proxyRes, err := client.CreateWorkspaceProxy(ctx, codersdk.CreateWorkspaceProxyRequest{
+			Name:             namesgenerator.GetRandomName(1),
+			Icon:             "/emojis/flag.png",
+			URL:              "https://" + namesgenerator.GetRandomName(1) + ".com",
+			WildcardHostname: opts.AppHost,
+		})
+		require.NoError(t, err)
+
+		appHostRegex, err := httpapi.CompileHostnamePattern(opts.AppHost)
+		require.NoError(t, err, "app host regex should compile")
+
+		// Make the external proxy service
+		proxy, err := wsproxy.New(&wsproxy.Options{
+			Logger:           api.Logger,
+			PrimaryAccessURL: api.AccessURL,
+			// TODO: @emyrk give this an access url
+			AccessURL:          nil,
+			AppHostname:        opts.AppHost,
+			AppHostnameRegex:   appHostRegex,
+			RealIPConfig:       api.RealIPConfig,
+			AppSecurityKey:     api.AppSecurityKey,
+			Tracing:            api.TracerProvider,
+			PrometheusRegistry: api.PrometheusRegistry,
+			APIRateLimit:       api.APIRateLimit,
+			SecureAuthCookie:   api.SecureAuthCookie,
+			ProxySessionToken:  proxyRes.ProxyToken,
+		})
+		require.NoError(t, err, "wsproxy should be created")
+
+		// TODO: Run the wsproxy, http.Serve
+		_ = proxy
+
+		return &apptest.Deployment{
+			Options:        opts,
+			Client:         client,
+			FirstUser:      user,
+			PathAppBaseURL: client.URL,
+		}
+	})
+}
