feedback

aslilac · aslilac · commit c6d37cabd2db · 2025-01-14T17:54:51.000Z
diff --git a/site/site.go b/site/site.go
@@ -162,7 +162,7 @@ func New(opts *Options) *Handler {
 
 	handler.installScript, err = parseInstallScript(opts.SiteFS, opts.BuildInfo)
 	if err != nil {
-		_ = xerrors.Errorf("install.sh will be unavailable: %w", err)
+		_, _ = fmt.Fprintf(os.Stderr, "install.sh will be unavailable: %v", err.Error())
 	}
 
 	return handler
diff --git a/site/static/install.sh b/site/static/install.sh
@@ -5,12 +5,12 @@ set -eu
 # See https://github.com/coder/coder#install
 #
 # To run:
-# curl -L {{ .Origin }}/install.sh | sh
+# curl -fsSL "{{ .Origin }}/install.sh" | sh
 
 usage() {
 	arg0="$0"
 	if [ "$0" = sh ]; then
-		arg0="curl -fsSL {{ .Origin }}/install.sh | sh -s --"
+		arg0="curl -fsSL \"{{ .Origin }}/install.sh\" | sh -s --"
 	else
 		not_curl_usage="The latest script is available at {{ .Origin }}/install.sh
 "

Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,7 @@ func New(opts Options) Handler {`
`162`	`162`
`163`	`163`	`handler.installScript, err = parseInstallScript(opts.SiteFS, opts.BuildInfo)`
`164`	`164`	`if err != nil {`
`165`		`- _ = xerrors.Errorf("install.sh will be unavailable: %w", err)`
	`165`	`+ _, _ = fmt.Fprintf(os.Stderr, "install.sh will be unavailable: %v", err.Error())`
`166`	`166`	`}`
`167`	`167`
`168`	`168`	`return handler`
Original file line number	Diff line number	Diff line change
`@@ -5,12 +5,12 @@ set -eu`
`5`	`5`	`# See https://github.com/coder/coder#install`
`6`	`6`	`#`
`7`	`7`	`# To run:`
`8`		`-# curl -L {{ .Origin }}/install.sh \| sh`
	`8`	`+# curl -fsSL "{{ .Origin }}/install.sh" \| sh`
`9`	`9`
`10`	`10`	`usage() {`
`11`	`11`	`arg0="$0"`
`12`	`12`	`if [ "$0" = sh ]; then`
`13`		`- arg0="curl -fsSL {{ .Origin }}/install.sh \| sh -s --"`
	`13`	`+ arg0="curl -fsSL \"{{ .Origin }}/install.sh\" \| sh -s --"`
`14`	`14`	`else`
`15`	`15`	`not_curl_usage="The latest script is available at {{ .Origin }}/install.sh`
`16`	`16`	`"`