Skip to content

Commit c867012

Browse files
committed
protect against nilpointer exceptions in dynamic parameter functions
1 parent c5ab3b9 commit c867012

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

coderd/dynamicparameters/presets.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ import (
99
// CheckPresets extracts the preset related diagnostics from a template version preset
1010
func CheckPresets(output *preview.Output, diags hcl.Diagnostics) *DiagnosticError {
1111
de := presetValidationError(diags)
12+
if output == nil {
13+
return de
14+
}
15+
1216
presets := output.Presets
1317
for _, preset := range presets {
1418
if hcl.Diagnostics(preset.Diagnostics).HasErrors() {

coderd/dynamicparameters/tags.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,10 @@ import (
1111

1212
func CheckTags(output *preview.Output, diags hcl.Diagnostics) *DiagnosticError {
1313
de := tagValidationError(diags)
14+
if output == nil {
15+
return de
16+
}
17+
1418
failedTags := output.WorkspaceTags.UnusableTags()
1519
if len(failedTags) == 0 && !de.HasError() {
1620
return nil // No errors, all is good!

0 commit comments

Comments
 (0)