Fix tests

presleyp · presleyp · commit cb20ccd32971 · 2022-08-25T18:37:30.000Z
diff --git a/site/src/components/Navbar/Navbar.test.tsx b/site/src/components/Navbar/Navbar.test.tsx
@@ -1,40 +1,54 @@
-import { screen } from "@testing-library/react"
+import { render, screen, waitFor } from "@testing-library/react"
 import { rest } from "msw"
 import {
   MockEntitlementsWithAuditLog,
   MockMemberPermissions,
   MockUser,
-  render,
 } from "testHelpers/renderHelpers"
 import { server } from "testHelpers/server"
-import { Navbar } from "./Navbar"
+import { App } from "app"
 
+/**
+ * The LicenseBanner, mounted above the AppRouter, fetches entitlements. Thus, to test their
+ * effects, we must test at the App level and `waitFor` the fetch to be done.
+ */
 describe("Navbar", () => {
   it("shows Audit Log link when permitted and entitled", async () => {
     server.use(
-      rest.get("/api/entitlements", (req, res, ctx) => {
+      rest.get("/api/v2/entitlements", (req, res, ctx) => {
         return res(ctx.status(200), ctx.json(MockEntitlementsWithAuditLog))
       }),
     )
-    render(<Navbar />)
-    const link = await screen.findByText("Audit")
-    expect(link).toBeDefined()
+    render(<App />)
+    await waitFor(() => {
+      const link = screen.getByText("Audit")
+      expect(link).toBeDefined()
+    })
   })
 
-  it("does not show Audit Log link when not entitled", () => {
-    render(<Navbar />)
-    const link = screen.getByText("Audit")
-    expect(link).not.toBeDefined()
+  it("does not show Audit Log link when not entitled", async () => {
+    render(<App />)
+    await waitFor(() => {
+      const link = screen.queryByText("Audit")
+      expect(link).toBe(null)
+    })
   })
 
-  it("does not show Audit Log link when not permitted via role", () => {
+  it("does not show Audit Log link when not permitted via role", async () => {
     server.use(
       rest.post(`/api/v2/users/${MockUser.id}/authorization`, async (req, res, ctx) => {
         return res(ctx.status(200), ctx.json(MockMemberPermissions))
       }),
     )
-    render(<Navbar />)
-    const link = screen.getByText("Audit")
-    expect(link).not.toBeDefined()
+    server.use(
+      rest.get("/api/v2/entitlements", (req, res, ctx) => {
+        return res(ctx.status(200), ctx.json(MockEntitlementsWithAuditLog))
+      }),
+    )
+    render(<App />)
+    await waitFor(() => {
+      const link = screen.queryByText("Audit")
+      expect(link).toBe(null)
+    })
   })
 })
