Skip to content

Commit cb9428e

Browse files
committed
fixup! add back max_ttl and put restart_requirement behind feature flag
1 parent fd26e69 commit cb9428e

File tree

5 files changed

+14
-2
lines changed

5 files changed

+14
-2
lines changed

coderd/database/modelqueries.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ func (q *sqlQuerier) GetAuthorizedTemplates(ctx context.Context, arg GetTemplate
7171
&i.ActiveVersionID,
7272
&i.Description,
7373
&i.DefaultTTL,
74+
&i.MaxTTL,
7475
&i.CreatedBy,
7576
&i.Icon,
7677
&i.UserACL,
@@ -82,6 +83,8 @@ func (q *sqlQuerier) GetAuthorizedTemplates(ctx context.Context, arg GetTemplate
8283
&i.FailureTTL,
8384
&i.InactivityTTL,
8485
&i.LockedTTL,
86+
&i.RestartRequirementDaysOfWeek,
87+
&i.RestartRequirementWeeks,
8588
); err != nil {
8689
return nil, xerrors.Errorf("scan: %w", err)
8790
}

codersdk/templates.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ type Template struct {
3030
Icon string `json:"icon"`
3131
DefaultTTLMillis int64 `json:"default_ttl_ms"`
3232
// TODO(@dean): remove max_ttl once restart_requirement is matured
33-
MaxTTLMillis int64 `json:"max_ttl_ms,omitempty"`
33+
MaxTTLMillis int64 `json:"max_ttl_ms"`
3434
// RestartRequirement is an enterprise feature. Its value is only used if
3535
// your license is entitled to use the advanced template scheduling feature.
3636
RestartRequirement TemplateRestartRequirement `json:"restart_requirement"`

site/src/api/typesGenerated.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -866,7 +866,7 @@ export interface Template {
866866
readonly description: string
867867
readonly icon: string
868868
readonly default_ttl_ms: number
869-
readonly max_ttl_ms?: number
869+
readonly max_ttl_ms: number
870870
readonly restart_requirement: TemplateRestartRequirement
871871
readonly created_by_id: string
872872
readonly created_by_name: string

site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsPage.test.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,10 @@ const validFormValues: FormValues = {
2626
allow_user_cancel_workspace_jobs: false,
2727
allow_user_autostart: false,
2828
allow_user_autostop: false,
29+
restart_requirement: {
30+
days_of_week: [],
31+
weeks: 1,
32+
},
2933
failure_ttl_ms: 0,
3034
inactivity_ttl_ms: 0,
3135
locked_ttl_ms: 0,

site/src/pages/TemplateSettingsPage/TemplateSchedulePage/TemplateScheduleForm/TemplateScheduleForm.tsx

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,11 @@ export const TemplateScheduleForm: FC<TemplateScheduleForm> = ({
7070
? template.locked_ttl_ms / MS_DAY_CONVERSION
7171
: 0,
7272

73+
restart_requirement: {
74+
days_of_week: template.restart_requirement.days_of_week,
75+
weeks: template.restart_requirement.weeks,
76+
},
77+
7378
allow_user_autostart: template.allow_user_autostart,
7479
allow_user_autostop: template.allow_user_autostop,
7580
failure_cleanup_enabled:

0 commit comments

Comments
 (0)