linting

Emyrk · Emyrk · commit cbb9432504d2 · 2024-05-24T12:00:16.000-10:00
diff --git a/cli/organizationroles.go b/cli/organizationroles.go
@@ -388,7 +388,7 @@ func roleToTableView(role codersdk.Role) roleTableRow {
 		Name:                    role.Name,
 		DisplayName:             role.DisplayName,
 		SitePermissions:         fmt.Sprintf("%d permissions", len(role.SitePermissions)),
-		OrganizationPermissions: fmt.Sprintf("%s", orgPermissionString(role.OrganizationPermissions)),
+		OrganizationPermissions: orgPermissionString(role.OrganizationPermissions),
 		UserPermissions:         fmt.Sprintf("%d permissions", len(role.UserPermissions)),
 	}
 }
diff --git a/enterprise/cli/organization_test.go b/enterprise/cli/organization_test.go
@@ -1,4 +1,4 @@
-package cli
+package cli_test
 
 import (
 	"bytes"
@@ -31,7 +31,8 @@ func TestEditOrganizationRoles(t *testing.T) {
 				Features: license.Features{
 					codersdk.FeatureCustomRoles: 1,
 				},
-			}})
+			},
+		})
 
 		ctx := testutil.Context(t, testutil.WaitMedium)
 		inv, root := clitest.New(t, "organization", "roles", "edit", "--stdin")
@@ -53,6 +54,7 @@ func TestEditOrganizationRoles(t *testing.T) {
     "assignable": false,
     "built_in": false
   }`, owner.OrganizationID.String()))
+		//nolint:gocritic // only owners can edit roles
 		clitest.SetupConfig(t, client, root)
 
 		buf := new(bytes.Buffer)

Original file line number	Diff line number	Diff line change
`@@ -388,7 +388,7 @@ func roleToTableView(role codersdk.Role) roleTableRow {`
`388`	`388`	`Name: role.Name,`
`389`	`389`	`DisplayName: role.DisplayName,`
`390`	`390`	`SitePermissions: fmt.Sprintf("%d permissions", len(role.SitePermissions)),`
`391`		`- OrganizationPermissions: fmt.Sprintf("%s", orgPermissionString(role.OrganizationPermissions)),`
	`391`	`+ OrganizationPermissions: orgPermissionString(role.OrganizationPermissions),`
`392`	`392`	`UserPermissions: fmt.Sprintf("%d permissions", len(role.UserPermissions)),`
`393`	`393`	`}`
`394`	`394`	`}`