Add test for Windows resize

kylecarbs · kylecarbs · commit cbbae07c2c02 · 2022-02-17T15:37:57.000Z
diff --git a/pty/pty_windows.go b/pty/pty_windows.go
@@ -41,7 +41,7 @@ func newPty() (PTY, error) {
 	}
 	ptyWindows.outputRead, ptyWindows.outputWrite, err = os.Pipe()
 
-	consoleSize := uintptr((int32(20) << 16) | int32(20))
+	consoleSize := uintptr(80) + (uintptr(80) << 16)
 	ret, _, err := procCreatePseudoConsole.Call(
 		consoleSize,
 		uintptr(ptyWindows.inputRead.Fd()),
diff --git a/pty/start_windows_test.go b/pty/start_windows_test.go
@@ -10,9 +10,19 @@ import (
 	"github.com/coder/coder/pty/ptytest"
 )
 
+func TestMain(m *testing.M) {
+	goleak.VerifyTestMain(m)
+}
+
 func TestStart(t *testing.T) {
 	t.Run("Echo", func(t *testing.T) {
 		pty := ptytest.Start(t, exec.Command("cmd.exe", "/c", "echo", "test"))
 		pty.ExpectMatch("test")
 	})
+
+	t.Run("Resize", func(t *testing.T) {
+		pty := ptytest.Start(t, exec.Command("cmd.exe"))
+		err := pty.Resize(100, 50)
+		require.NoError(t, err)
+	})
 }

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ func newPty() (PTY, error) {`
`41`	`41`	`}`
`42`	`42`	`ptyWindows.outputRead, ptyWindows.outputWrite, err = os.Pipe()`
`43`	`43`
`44`		`- consoleSize := uintptr((int32(20) << 16) \| int32(20))`
	`44`	`+ consoleSize := uintptr(80) + (uintptr(80) << 16)`
`45`	`45`	`ret, _, err := procCreatePseudoConsole.Call(`
`46`	`46`	`consoleSize,`
`47`	`47`	`uintptr(ptyWindows.inputRead.Fd()),`