test push notifications endpoint

johnstcn · johnstcn · commit cbff3cac0cac · 2025-03-26T16:36:58.000Z
diff --git a/coderd/notifications_test.go b/coderd/notifications_test.go
@@ -412,6 +412,10 @@ func TestPushNotificationSubscription(t *testing.T) {
 		require.NoError(t, err, "create notification push subscription")
 		require.True(t, <-handlerCalled, "handler should have been called")
 
+		err = memberClient.TestPushNotification(ctx)
+		require.NoError(t, err, "test push notification")
+		require.True(t, <-handlerCalled, "handler should have been called again")
+
 		err = memberClient.DeleteNotificationPushSubscription(ctx, "me", codersdk.DeletePushNotificationSubscription{
 			Endpoint: server.URL,
 		})
diff --git a/codersdk/deployment.go b/codersdk/deployment.go
@@ -700,6 +700,12 @@ type NotificationsConfig struct {
 	Webhook NotificationsWebhookConfig `json:"webhook" typescript:",notnull"`
 	// Inbox settings.
 	Inbox NotificationsInboxConfig `json:"inbox" typescript:",notnull"`
+	// Push notification settings.
+	Push NotificationsPushConfig `json:"push" typescript:",notnull"`
+}
+
+type NotificationsPushConfig struct {
+	Enabled serpent.Bool `json:"enabled" typescript:",notnull"`
 }
 
 // Are either of the notification methods enabled?
@@ -1001,6 +1007,11 @@ func (c *DeploymentValues) Options() serpent.OptionSet {
 			Parent: &deploymentGroupNotifications,
 			YAML:   "inbox",
 		}
+		deploymentGroupNotificationsPush = serpent.Group{
+			Name:   "Push",
+			Parent: &deploymentGroupNotifications,
+			YAML:   "push",
+		}
 	)
 
 	httpAddress := serpent.Option{
@@ -2968,6 +2979,17 @@ Write out the current server config as YAML to stdout.`,
 			Annotations: serpent.Annotations{}.Mark(annotationFormatDuration, "true"),
 			Hidden:      true, // Hidden because most operators should not need to modify this.
 		},
+		// Push notifications.
+		{
+			Name:        "Notifications: Push: Enabled",
+			Description: "Enable push notifications using VAPID.",
+			Flag:        "notifications-push-enabled",
+			Env:         "CODER_NOTIFICATIONS_PUSH_ENABLED",
+			Value:       &c.Notifications.Push.Enabled,
+			Default:     "false",
+			Group:       &deploymentGroupNotificationsPush,
+			YAML:        "enabled",
+		},
 	}
 
 	return opts
diff --git a/codersdk/notifications.go b/codersdk/notifications.go
@@ -265,3 +265,19 @@ func (c *Client) DeleteNotificationPushSubscription(ctx context.Context, user st
 	}
 	return nil
 }
+
+func (c *Client) TestPushNotification(ctx context.Context) error {
+	res, err := c.Request(ctx, http.MethodPost, fmt.Sprintf("/api/v2/users/%s/notifications/push/test", Me), PushNotification{
+		Title: "It's working!",
+		Body:  "You've subscribed to push notifications.",
+	})
+	if err != nil {
+		return err
+	}
+	defer res.Body.Close()
+
+	if res.StatusCode != http.StatusNoContent {
+		return ReadBodyAsError(res)
+	}
+	return nil
+}
