fi stop tracing 4xx http status codes as errors (#3707)

f0ssel · web-flow · commit ccabec6dd187 · 2022-08-26T15:18:42.000Z
diff --git a/coderd/tracing/httpmw.go b/coderd/tracing/httpmw.go
@@ -56,7 +56,7 @@ func EndHTTPSpan(r *http.Request, status int) {
 		status = http.StatusOK
 	}
 	span.SetAttributes(semconv.HTTPStatusCodeKey.Int(status))
-	spanStatus, spanMessage := semconv.SpanStatusFromHTTPStatusCode(status)
+	spanStatus, spanMessage := semconv.SpanStatusFromHTTPStatusCodeAndSpanKind(status, trace.SpanKindServer)
 	span.SetStatus(spanStatus, spanMessage)
 
 	// finally end span

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ func EndHTTPSpan(r *http.Request, status int) {`
`56`	`56`	`status = http.StatusOK`
`57`	`57`	`}`
`58`	`58`	`span.SetAttributes(semconv.HTTPStatusCodeKey.Int(status))`
`59`		`- spanStatus, spanMessage := semconv.SpanStatusFromHTTPStatusCode(status)`
	`59`	`+ spanStatus, spanMessage := semconv.SpanStatusFromHTTPStatusCodeAndSpanKind(status, trace.SpanKindServer)`
`60`	`60`	`span.SetStatus(spanStatus, spanMessage)`
`61`	`61`
`62`	`62`	`// finally end span`