Fix regepx default

Emyrk · Emyrk · commit cd5dd2f54990 · 2023-08-03T11:33:33.000-05:00
diff --git a/codersdk/deployment.go b/codersdk/deployment.go
@@ -1082,7 +1082,7 @@ when required by your organization's security policy.`,
 			Description: "If provided any group name not matching the regex is ignored. This allows for filtering out groups that are not needed. This filter is applied after the group mapping.",
 			Flag:        "oidc-group-regex-filter",
 			Env:         "CODER_OIDC_GROUP_REGEX_FILTER",
-			Default:     "*",
+			Default:     ".*",
 			Value:       &c.OIDC.GroupRegexFilter,
 			Group:       &deploymentGroupOIDC,
 			YAML:        "groupRegexFilter",
diff --git a/enterprise/coderd/userauth_test.go b/enterprise/coderd/userauth_test.go
@@ -386,6 +386,7 @@ func TestGroupSync(t *testing.T) {
 			modCfg: func(cfg *coderd.OIDCConfig) {
 				// Disable group sync
 				cfg.GroupField = ""
+				cfg.GroupFilter = regexp.MustCompile(".*")
 			},
 			initialOrgGroups:   []string{"a", "b", "c", "d"},
 			initialUserGroups:  []string{"b", "c", "d"},
@@ -414,6 +415,7 @@ func TestGroupSync(t *testing.T) {
 			// From a,c,b -> []
 			name: "RemoveAllGroups",
 			modCfg: func(cfg *coderd.OIDCConfig) {
+				cfg.GroupFilter = regexp.MustCompile(".*")
 			},
 			initialOrgGroups:   []string{"a", "b", "c", "d"},
 			initialUserGroups:  []string{"a", "b", "c"},
