Skip to content

Commit cede0ac

Browse files
mtojekmtojek
committed
fix: load test increase timeout
1 parent fb22c21 commit cede0ac

File tree

1 file changed

+6
-12
lines changed

1 file changed

+6
-12
lines changed

‎loadtest/reconnectingpty/run_test.go

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package reconnectingpty_test
33
import (
44
"bytes"
55
"context"
6-
"runtime"
76
"testing"
87
"time"
98

@@ -23,9 +22,6 @@ import (
2322

2423
func Test_Runner(t *testing.T) {
2524
t.Parallel()
26-
if runtime.GOOS != "linux" {
27-
t.Skip("PTY is flakey on non-Linux platforms")
28-
}
2925

3026
t.Run("OK", func(t *testing.T) {
3127
t.Parallel()
@@ -81,7 +77,6 @@ func Test_Runner(t *testing.T) {
8177

8278
t.Run("Timeout", func(t *testing.T) {
8379
t.Parallel()
84-
t.Skip("Flaky: https://github.com/coder/coder/issues/5187")
8580

8681
t.Run("NoTimeout", func(t *testing.T) {
8782
t.Parallel()
@@ -97,7 +92,7 @@ func Test_Runner(t *testing.T) {
9792
LogOutput: true,
9893
})
9994

100-
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitShort)
95+
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
10196
defer cancel()
10297

10398
logs := bytes.NewBuffer(nil)
@@ -121,7 +116,7 @@ func Test_Runner(t *testing.T) {
121116
LogOutput: true,
122117
})
123118

124-
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitShort)
119+
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
125120
defer cancel()
126121

127122
logs := bytes.NewBuffer(nil)
@@ -151,7 +146,7 @@ func Test_Runner(t *testing.T) {
151146
LogOutput: true,
152147
})
153148

154-
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitShort)
149+
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
155150
defer cancel()
156151

157152
logs := bytes.NewBuffer(nil)
@@ -176,7 +171,7 @@ func Test_Runner(t *testing.T) {
176171
LogOutput: true,
177172
})
178173

179-
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitShort)
174+
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
180175
defer cancel()
181176

182177
logs := bytes.NewBuffer(nil)
@@ -190,7 +185,6 @@ func Test_Runner(t *testing.T) {
190185

191186
t.Run("ExpectOutput", func(t *testing.T) {
192187
t.Parallel()
193-
t.Skip("Flaky: https://github.com/coder/coder/issues/5187")
194188

195189
t.Run("Matches", func(t *testing.T) {
196190
t.Parallel()
@@ -206,7 +200,7 @@ func Test_Runner(t *testing.T) {
206200
LogOutput: false,
207201
})
208202

209-
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitShort)
203+
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
210204
defer cancel()
211205

212206
logs := bytes.NewBuffer(nil)
@@ -230,7 +224,7 @@ func Test_Runner(t *testing.T) {
230224
LogOutput: false,
231225
})
232226

233-
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitShort)
227+
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
234228
defer cancel()
235229

236230
logs := bytes.NewBuffer(nil)

0 commit comments

Comments
 (0)