Skip to content

Commit d0085c5

Browse files
committed
Test frontend
1 parent 7c1a63f commit d0085c5

File tree

2 files changed

+41
-5
lines changed

2 files changed

+41
-5
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
import { render } from "testHelpers/renderHelpers"
2+
import { DAUChart, Language } from "./DAUCharts"
3+
4+
import { screen } from "@testing-library/react"
5+
import { ResizeObserver } from "resize-observer"
6+
7+
Object.defineProperty(window, "ResizeObserver", {
8+
value: ResizeObserver,
9+
})
10+
11+
describe("DAUChart", () => {
12+
it("renders a helpful paragraph on empty state", async () => {
13+
render(
14+
<DAUChart
15+
userMetricsData={{
16+
entries: [],
17+
}}
18+
/>,
19+
)
20+
21+
await screen.findAllByText(Language.loadingText)
22+
})
23+
it("renders a graph", async () => {
24+
render(
25+
<DAUChart
26+
userMetricsData={{
27+
entries: [{ date: "2020-01-01", daus: 1 }],
28+
}}
29+
/>,
30+
)
31+
32+
await screen.findAllByText(Language.chartTitle)
33+
})
34+
})

site/src/pages/UsersPage/DAUCharts.tsx

+7-5
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,18 @@ ChartJS.register(CategoryScale, LinearScale, PointElement, LineElement, Title, T
2626
export interface DAUChartProps {
2727
userMetricsData: TypesGen.DAUsResponse
2828
}
29+
export const Language = {
30+
loadingText: "DAU stats are loading. Check back later.",
31+
chartTitle: "Daily Active Users",
32+
}
2933

3034
export const DAUChart: FC<DAUChartProps> = ({ userMetricsData }) => {
3135
const theme: Theme = useTheme()
3236

3337
if (userMetricsData.entries.length === 0) {
3438
return (
3539
<div style={{ marginTop: "-20px" }}>
36-
<p>DAU stats are loading. Check back later.</p>
40+
<p>{Language.loadingText}</p>
3741
</div>
3842
)
3943
}
@@ -73,12 +77,10 @@ export const DAUChart: FC<DAUChartProps> = ({ userMetricsData }) => {
7377
<>
7478
<WorkspaceSection>
7579
<Stack direction="row" spacing={1} alignItems="center">
76-
<h3>Daily Active Users</h3>
80+
<h3>{Language.chartTitle}</h3>
7781
<HelpTooltip size="small">
7882
<HelpTooltipTitle>How do we calculate DAUs?</HelpTooltipTitle>
79-
<HelpTooltipText>
80-
We use daily, unique workspace connection traffic to compute DAUs.
81-
</HelpTooltipText>
83+
<HelpTooltipText>We use workspace connection traffic to compute DAUs.</HelpTooltipText>
8284
</HelpTooltip>
8385
</Stack>
8486
<Line

0 commit comments

Comments
 (0)