ability to filter users based on login type

utsavll0 · utsavll0 · commit d0e840a34abc · 2025-04-03T00:53:03.000-04:00
diff --git a/coderd/database/modelqueries.go b/coderd/database/modelqueries.go
@@ -395,6 +395,7 @@ func (q *sqlQuerier) GetAuthorizedUsers(ctx context.Context, arg GetUsersParams,
 		arg.CreatedAfter,
 		arg.IncludeSystem,
 		arg.GithubComUserID,
+		pq.Array(arg.LoginType),
 		arg.OffsetOpt,
 		arg.LimitOpt,
 	)
diff --git a/coderd/database/queries.sql.go b/coderd/database/queries.sql.go
diff --git a/coderd/database/queries/users.sql b/coderd/database/queries/users.sql
@@ -237,6 +237,12 @@ WHERE
 			github_com_user_id = @github_com_user_id
 		ELSE true
 	END
+	-- Filter by login_type
+	AND CASE
+		WHEN cardinality(@login_type :: login_type[]) > 0 THEN
+			login_type = ANY(@login_type :: login_type[])
+		ELSE true
+	END
 	-- End of filters
 
 	-- Authorize Filter clause will be injected below in GetAuthorizedUsers
diff --git a/coderd/searchquery/search.go b/coderd/searchquery/search.go
@@ -88,6 +88,7 @@ func Users(query string) (database.GetUsersParams, []codersdk.ValidationError) {
 		CreatedAfter:    parser.Time3339Nano(values, time.Time{}, "created_after"),
 		CreatedBefore:   parser.Time3339Nano(values, time.Time{}, "created_before"),
 		GithubComUserID: parser.Int64(values, 0, "github_com_user_id"),
+		LoginType:       httpapi.ParseCustomList(parser, values, []database.LoginType{}, "login_type", httpapi.ParseEnum[database.LoginType]),
 	}
 	parser.ErrorExcessParams(values)
 	return filter, parser.Errors
diff --git a/coderd/users.go b/coderd/users.go
@@ -306,6 +306,7 @@ func (api *API) GetUsers(rw http.ResponseWriter, r *http.Request) ([]database.Us
 		CreatedAfter:    params.CreatedAfter,
 		CreatedBefore:   params.CreatedBefore,
 		GithubComUserID: params.GithubComUserID,
+		LoginType: 	 	 params.LoginType,
 		// #nosec G115 - Pagination offsets are small and fit in int32
 		OffsetOpt: int32(paginationParams.Offset),
 		// #nosec G115 - Pagination limits are small and fit in int32

Original file line number	Diff line number	Diff line change
`@@ -395,6 +395,7 @@ func (q *sqlQuerier) GetAuthorizedUsers(ctx context.Context, arg GetUsersParams,`
`395`	`395`	`arg.CreatedAfter,`
`396`	`396`	`arg.IncludeSystem,`
`397`	`397`	`arg.GithubComUserID,`
	`398`	`+ pq.Array(arg.LoginType),`
`398`	`399`	`arg.OffsetOpt,`
`399`	`400`	`arg.LimitOpt,`
`400`	`401`	`)`
Original file line number	Diff line number	Diff line change
`@@ -88,6 +88,7 @@ func Users(query string) (database.GetUsersParams, []codersdk.ValidationError) {`
`88`	`88`	`CreatedAfter: parser.Time3339Nano(values, time.Time{}, "created_after"),`
`89`	`89`	`CreatedBefore: parser.Time3339Nano(values, time.Time{}, "created_before"),`
`90`	`90`	`GithubComUserID: parser.Int64(values, 0, "github_com_user_id"),`
	`91`	`+ LoginType: httpapi.ParseCustomList(parser, values, []database.LoginType{}, "login_type", httpapi.ParseEnum[database.LoginType]),`
`91`	`92`	`}`
`92`	`93`	`parser.ErrorExcessParams(values)`
`93`	`94`	`return filter, parser.Errors`