Address PR comments

mtojek · mtojek · commit d1165664a1a7 · 2024-01-17T12:20:24.000+01:00
diff --git a/coderd/httpapi/name.go b/coderd/httpapi/name.go
@@ -82,8 +82,8 @@ func TemplateDisplayNameValid(str string) error {
 
 // UserRealNameValid returns whether the input string is a valid real user name.
 func UserRealNameValid(str string) error {
-	if len(str) > 64 {
-		return xerrors.New("must be <= 64 characters")
+	if len(str) > 128 {
+		return xerrors.New("must be <= 128 characters")
 	}
 
 	trimmed := strings.TrimSpace(str)
diff --git a/coderd/httpapi/name_test.go b/coderd/httpapi/name_test.go
@@ -224,6 +224,10 @@ func TestUserRealNameValid(t *testing.T) {
 		{"Mr Bean", true},
 		{"Severus Snape", true},
 		{"Prof. Albus Percival Wulfric Brian Dumbledore", true},
+		{"Pablo Diego José Francisco de Paula Juan Nepomuceno María de los Remedios Cipriano de la Santísima Trinidad Ruiz y Picasso", true},
+		{"Hector Ó hEochagáin", true},
+		{"Małgorzata Kalinowska-Iszkowska", true},
+		{"成龍", true},
 		{". .", true},
 
 		{"Lord Voldemort ", false},

Original file line number	Diff line number	Diff line change
`@@ -82,8 +82,8 @@ func TemplateDisplayNameValid(str string) error {`
`82`	`82`
`83`	`83`	`// UserRealNameValid returns whether the input string is a valid real user name.`
`84`	`84`	`func UserRealNameValid(str string) error {`
`85`		`- if len(str) > 64 {`
`86`		`- return xerrors.New("must be <= 64 characters")`
	`85`	`+ if len(str) > 128 {`
	`86`	`+ return xerrors.New("must be <= 128 characters")`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`trimmed := strings.TrimSpace(str)`