Skip to content

Commit d2bb9f3

Browse files
committed
suggestions from review
1 parent 0dffcbe commit d2bb9f3

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

docs/admin/setup/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ If you are providing TLS certificates directly to the Coder server, either
6060
options (these both take a comma separated list of files; list certificates
6161
and their respective keys in the same order).
6262

63-
After you enable a wildcard sub-domain, [disable path-based apps](../../tutorials/best-practices/security-best-practices.md#disable-path-based-apps).
63+
After you enable the wildcard access URL, you should [disable path-based apps](../../tutorials/best-practices/security-best-practices.md#disable-path-based-apps) for security.
6464

6565
## TLS & Reverse Proxy
6666

docs/tutorials/best-practices/security-best-practices.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,10 @@ determining the nature and scope of the impact.
6868

6969
### Disable path-based apps
7070

71-
For production deployments, disable path-based apps.
71+
For production deployments, we recommend that you disable path-based apps after you've configured a wildcard access URL.
7272

73-
Path-based apps share the same origin as the Coder API.
74-
This setup is convenient for demos, but can expose the deployment to cross-site-scripting (XSS) attacks in production.
73+
Path-based apps share the same origin as the Coder API, which can be convenient for trialing Coder,
74+
but can expose the deployment to cross-site-scripting (XSS) attacks in production.
7575
A malicious workspace could reuse Coder cookies to call the API or interact with other workspaces owned by the same user.
7676

7777
1. [Enable sub-domain apps with a wildcard DNS record](../../admin/setup/index.md#wildcard-access-url) (like `*.coder.example.com`)
@@ -86,7 +86,7 @@ A malicious workspace could reuse Coder cookies to call the API or interact with
8686

8787
By default, Coder mitigates the impact of having path-based apps enabled, but we still recommend disabling it to prevent malicious workspaces accessing other workspaces owned by the same user or performing requests against the Coder API.
8888

89-
If you do keep path-based apps enabled, Coder limits the risk:
89+
If you do keep path-based apps enabled:
9090

9191
- Path-based apps cannot be shared with other users unless you start the Coder server with `--dangerous-allow-path-app-sharing`.
9292
- Users with the site `owner` role cannot use their admin privileges to access path-based apps for workspace unless the server is started with `--dangerous-allow-path-app-site-owner-access`.

0 commit comments

Comments
 (0)