fix: do not allow selection of unsuccessful versions (#10941)

f0ssel · web-flow · commit d41f9f8b4768 · 2023-11-29T13:01:17.000-05:00
diff --git a/site/src/pages/WorkspacePage/ChangeVersionDialog.tsx b/site/src/pages/WorkspacePage/ChangeVersionDialog.tsx
@@ -36,6 +36,9 @@ export const ChangeVersionDialog: FC<ChangeVersionDialogProps> = ({
   const [isAutocompleteOpen, setIsAutocompleteOpen] = useState(false);
   const selectedTemplateVersion = useRef<TemplateVersion | undefined>();
   const version = selectedTemplateVersion.current;
+  const validTemplateVersions = templateVersions?.filter((version) => {
+    return version.job.status === "succeeded";
+  });
 
   return (
     <ConfirmDialog
@@ -54,12 +57,12 @@ export const ChangeVersionDialog: FC<ChangeVersionDialogProps> = ({
       description={
         <Stack>
           <p>You are about to change the version of this workspace.</p>
-          {templateVersions ? (
+          {validTemplateVersions ? (
             <>
               <FormFields>
                 <Autocomplete
                   disableClearable
-                  options={templateVersions}
+                  options={validTemplateVersions}
                   defaultValue={defaultTemplateVersion}
                   id="template-version-autocomplete"
                   open={isAutocompleteOpen}
