fix

mtojek · mtojek · commit d48a8ba80acf · 2024-09-11T13:50:28.000+02:00
diff --git a/coderd/database/dbmem/dbmem.go b/coderd/database/dbmem/dbmem.go
@@ -3595,18 +3595,18 @@ func (q *FakeQuerier) GetReplicasUpdatedAfter(_ context.Context, updatedAt time.
 	return replicas, nil
 }
 
-func (q *FakeQuerier) GetReportGeneratorLogByUserAndTemplate(ctx context.Context, arg database.GetReportGeneratorLogByUserAndTemplateParams) (database.ReportGeneratorLog, error) {
+func (q *FakeQuerier) GetReportGeneratorLogByUserAndTemplate(_ context.Context, arg database.GetReportGeneratorLogByUserAndTemplateParams) (database.ReportGeneratorLog, error) {
 	err := validateDatabaseType(arg)
 	if err != nil {
 		return database.ReportGeneratorLog{}, err
 	}
 
 	q.mutex.RLock()
-	q.mutex.RUnlock()
+	defer q.mutex.RUnlock()
 
 	for _, record := range q.reportGeneratorLogs {
 		if record.UserID == arg.UserID && record.NotificationTemplateID == arg.NotificationTemplateID {
-			return database.ReportGeneratorLog(record), nil
+			return record, nil
 		}
 	}
 	return database.ReportGeneratorLog{}, sql.ErrNoRows

Original file line number	Diff line number	Diff line change
`@@ -3595,18 +3595,18 @@ func (q *FakeQuerier) GetReplicasUpdatedAfter(_ context.Context, updatedAt time.`
`3595`	`3595`	`return replicas, nil`
`3596`	`3596`	`}`
`3597`	`3597`
`3598`		`-func (q *FakeQuerier) GetReportGeneratorLogByUserAndTemplate(ctx context.Context, arg database.GetReportGeneratorLogByUserAndTemplateParams) (database.ReportGeneratorLog, error) {`
	`3598`	`+func (q *FakeQuerier) GetReportGeneratorLogByUserAndTemplate(_ context.Context, arg database.GetReportGeneratorLogByUserAndTemplateParams) (database.ReportGeneratorLog, error) {`
`3599`	`3599`	`err := validateDatabaseType(arg)`
`3600`	`3600`	`if err != nil {`
`3601`	`3601`	`return database.ReportGeneratorLog{}, err`
`3602`	`3602`	`}`
`3603`	`3603`
`3604`	`3604`	`q.mutex.RLock()`
`3605`		`- q.mutex.RUnlock()`
	`3605`	`+ defer q.mutex.RUnlock()`
`3606`	`3606`
`3607`	`3607`	`for _, record := range q.reportGeneratorLogs {`
`3608`	`3608`	`if record.UserID == arg.UserID && record.NotificationTemplateID == arg.NotificationTemplateID {`
`3609`		`- return database.ReportGeneratorLog(record), nil`
	`3609`	`+ return record, nil`
`3610`	`3610`	`}`
`3611`	`3611`	`}`
`3612`	`3612`	`return database.ReportGeneratorLog{}, sql.ErrNoRows`