Skip to content

Commit d5ddcbd

Browse files
authored
chore: fix flake in templates_test.go (#10875)
1 parent 7029ccf commit d5ddcbd

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

coderd/templates_test.go

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -525,6 +525,9 @@ func TestPatchTemplateMeta(t *testing.T) {
525525
user := coderdtest.CreateFirstUser(t, client)
526526
version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, nil)
527527
template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID)
528+
// It is unfortunate we need to sleep, but the test can fail if the
529+
// updatedAt is too close together.
530+
time.Sleep(time.Millisecond * 5)
528531

529532
req := codersdk.UpdateTemplateMeta{
530533
DeprecationMessage: ptr.Ref("APGL cannot deprecate"),
@@ -550,6 +553,9 @@ func TestPatchTemplateMeta(t *testing.T) {
550553
client, tplAdmin := coderdtest.CreateAnotherUser(t, owner, user.OrganizationID, rbac.RoleTemplateAdmin())
551554
version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, nil)
552555
template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID)
556+
// It is unfortunate we need to sleep, but the test can fail if the
557+
// updatedAt is too close together.
558+
time.Sleep(time.Millisecond * 5)
553559

554560
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
555561
defer cancel()
@@ -587,6 +593,10 @@ func TestPatchTemplateMeta(t *testing.T) {
587593
template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID, func(ctr *codersdk.CreateTemplateRequest) {
588594
ctr.DefaultTTLMillis = ptr.Ref(24 * time.Hour.Milliseconds())
589595
})
596+
// It is unfortunate we need to sleep, but the test can fail if the
597+
// updatedAt is too close together.
598+
time.Sleep(time.Millisecond * 5)
599+
590600
req := codersdk.UpdateTemplateMeta{
591601
DefaultTTLMillis: 0,
592602
}
@@ -618,6 +628,10 @@ func TestPatchTemplateMeta(t *testing.T) {
618628
template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID, func(ctr *codersdk.CreateTemplateRequest) {
619629
ctr.DefaultTTLMillis = ptr.Ref(24 * time.Hour.Milliseconds())
620630
})
631+
// It is unfortunate we need to sleep, but the test can fail if the
632+
// updatedAt is too close together.
633+
time.Sleep(time.Millisecond * 5)
634+
621635
req := codersdk.UpdateTemplateMeta{
622636
DefaultTTLMillis: -1,
623637
}

0 commit comments

Comments
 (0)