fiiiine steven

aslilac · aslilac · commit d72f4b25ed5b · 2025-04-09T16:55:19.000Z
diff --git a/coderd/httpapi/httpapi.go b/coderd/httpapi/httpapi.go
@@ -199,7 +199,7 @@ func Write(ctx context.Context, rw http.ResponseWriter, status int, response int
 	_, span := tracing.StartSpan(ctx)
 	defer span.End()
 
-	if rec, err := rbac.GetAuthzCheckRecorder(ctx); err == nil {
+	if rec, ok := rbac.GetAuthzCheckRecorder(ctx); ok {
 		// If you're here because you saw this header in a response, and you're
 		// trying to investigate the code, here are a couple of notable things
 		// for you to know:
@@ -230,7 +230,7 @@ func WriteIndent(ctx context.Context, rw http.ResponseWriter, status int, respon
 	_, span := tracing.StartSpan(ctx)
 	defer span.End()
 
-	if rec, err := rbac.GetAuthzCheckRecorder(ctx); err == nil {
+	if rec, ok := rbac.GetAuthzCheckRecorder(ctx); ok {
 		rw.Header().Set("x-dbauthz-checks", rec.String())
 	}
 
diff --git a/coderd/rbac/authz.go b/coderd/rbac/authz.go
@@ -822,13 +822,13 @@ func recordAuthzCheck(ctx context.Context, action policy.Action, object Object,
 	r.checks.Store(b.String(), authorized)
 }
 
-func GetAuthzCheckRecorder(ctx context.Context) (*AuthzCheckRecorder, error) {
+func GetAuthzCheckRecorder(ctx context.Context) (*AuthzCheckRecorder, bool) {
 	checks, ok := ctx.Value(authzCheckRecorderKey{}).(*AuthzCheckRecorder)
 	if !ok {
-		return nil, xerrors.New("no authz checks recorded")
+		return nil, false
 	}
 
-	return checks, nil
+	return checks, true
 }
 
 // String serializes all of the checks recorded, using the following syntax:

Original file line number	Diff line number	Diff line change
`@@ -822,13 +822,13 @@ func recordAuthzCheck(ctx context.Context, action policy.Action, object Object,`
`822`	`822`	`r.checks.Store(b.String(), authorized)`
`823`	`823`	`}`
`824`	`824`
`825`		`-func GetAuthzCheckRecorder(ctx context.Context) (*AuthzCheckRecorder, error) {`
	`825`	`+func GetAuthzCheckRecorder(ctx context.Context) (*AuthzCheckRecorder, bool) {`
`826`	`826`	`checks, ok := ctx.Value(authzCheckRecorderKey{}).(*AuthzCheckRecorder)`
`827`	`827`	`if !ok {`
`828`		`- return nil, xerrors.New("no authz checks recorded")`
	`828`	`+ return nil, false`
`829`	`829`	`}`
`830`	`830`
`831`		`- return checks, nil`
	`831`	`+ return checks, true`
`832`	`832`	`}`
`833`	`833`
`834`	`834`	`// String serializes all of the checks recorded, using the following syntax:`