fix test

sreya · sreya · commit d8fd43300131 · 2022-10-25T23:14:32.000Z
diff --git a/coderd/httpmw/groupparam.go b/coderd/httpmw/groupparam.go
@@ -55,6 +55,7 @@ func ExtractGroupByNameParam(db database.Store) func(http.Handler) http.Handler
 			}
 
 			ctx = context.WithValue(ctx, groupParamContextKey{}, group)
+			chi.RouteContext(ctx).URLParams.Add("organization", group.OrganizationID.String())
 			next.ServeHTTP(rw, r.WithContext(ctx))
 		})
 	}
diff --git a/enterprise/coderd/coderdenttest/coderdenttest_test.go b/enterprise/coderd/coderdenttest/coderdenttest_test.go
@@ -44,6 +44,7 @@ func TestAuthorizeAllEndpoints(t *testing.T) {
 	a := coderdtest.NewAuthTester(ctx, t, client, api.AGPL, admin)
 	a.URLParams["licenses/{id}"] = fmt.Sprintf("licenses/%d", license.ID)
 	a.URLParams["groups/{group}"] = fmt.Sprintf("groups/%s", group.ID.String())
+	a.URLParams["{groupName}"] = group.Name
 
 	skipRoutes, assertRoute := coderdtest.AGPLRoutes(a)
 	assertRoute["GET:/api/v2/entitlements"] = coderdtest.RouteCheck{
@@ -79,7 +80,11 @@ func TestAuthorizeAllEndpoints(t *testing.T) {
 		AssertAction: rbac.ActionRead,
 		AssertObject: groupObj,
 	}
-	assertRoute["PATCH:/api/v2/groups/{group}"] = coderdtest.RouteCheck{
+	assertRoute["GET:/api/v2/organizations/{organization}/groups/{groupName}"] = coderdtest.RouteCheck{
+		AssertAction: rbac.ActionRead,
+		AssertObject: groupObj,
+	}
+	assertRoute["GET:/api/v2/groups/{group}"] = coderdtest.RouteCheck{
 		AssertAction: rbac.ActionRead,
 		AssertObject: groupObj,
 	}

Original file line number	Diff line number	Diff line change
`@@ -55,6 +55,7 @@ func ExtractGroupByNameParam(db database.Store) func(http.Handler) http.Handler`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`ctx = context.WithValue(ctx, groupParamContextKey{}, group)`
	`58`	`+ chi.RouteContext(ctx).URLParams.Add("organization", group.OrganizationID.String())`
`58`	`59`	`next.ServeHTTP(rw, r.WithContext(ctx))`
`59`	`60`	`})`
`60`	`61`	`}`