remove test for not modified

mtojek · mtojek · commit da6775f8c454 · 2024-07-10T10:40:47.000+02:00
diff --git a/coderd/notifications_test.go b/coderd/notifications_test.go
@@ -60,24 +60,4 @@ func TestUpdateNotificationsSettings(t *testing.T) {
 		require.NoError(t, err)
 		require.Equal(t, expected, actual)
 	})
-
-	t.Run("Settings not modified", func(t *testing.T) {
-		t.Parallel()
-
-		client := coderdtest.New(t, nil)
-		_ = coderdtest.CreateFirstUser(t, client)
-
-		ctx := testutil.Context(t, testutil.WaitShort)
-
-		// given
-		expected := codersdk.NotificationsSettings{
-			NotifierPaused: false,
-		}
-		err := client.PutNotificationsSettings(ctx, expected)
-		require.NoError(t, err)
-
-		// then
-		err = client.PutNotificationsSettings(ctx, expected)
-		require.Error(t, err) // Error: notifications settings not modified
-	})
 }
diff --git a/codersdk/notifications.go b/codersdk/notifications.go
@@ -4,8 +4,6 @@ import (
 	"context"
 	"encoding/json"
 	"net/http"
-
-	"golang.org/x/xerrors"
 )
 
 type NotificationsSettings struct {
@@ -33,7 +31,7 @@ func (c *Client) PutNotificationsSettings(ctx context.Context, settings Notifica
 	defer res.Body.Close()
 
 	if res.StatusCode == http.StatusNotModified {
-		return xerrors.New("notifications settings not modified")
+		return nil
 	}
 	if res.StatusCode != http.StatusOK {
 		return ReadBodyAsError(res)
