fix(notifications): return default parameters for empty values

defelmnq · defelmnq · commit dabeac97ec67 · 2024-10-28T01:19:06.000Z
diff --git a/coderd/notifications/fetcher.go b/coderd/notifications/fetcher.go
@@ -38,6 +38,10 @@ func (n *notifier) fetchAppName(ctx context.Context) (string, error) {
 		}
 		return "", xerrors.Errorf("get application name: %w", err)
 	}
+
+	if appName == "" {
+		appName = notificationsDefaultAppName
+	}
 	return appName, nil
 }
 
@@ -49,5 +53,9 @@ func (n *notifier) fetchLogoURL(ctx context.Context) (string, error) {
 		}
 		return "", xerrors.Errorf("get logo URL: %w", err)
 	}
+
+	if logoURL == "" {
+		logoURL = notificationsDefaultLogoURL
+	}
 	return logoURL, nil
 }

Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,10 @@ func (n *notifier) fetchAppName(ctx context.Context) (string, error) {`
`38`	`38`	`}`
`39`	`39`	`return "", xerrors.Errorf("get application name: %w", err)`
`40`	`40`	`}`
	`41`	`+`
	`42`	`+ if appName == "" {`
	`43`	`+ appName = notificationsDefaultAppName`
	`44`	`+ }`
`41`	`45`	`return appName, nil`
`42`	`46`	`}`
`43`	`47`
`@@ -49,5 +53,9 @@ func (n *notifier) fetchLogoURL(ctx context.Context) (string, error) {`
`49`	`53`	`}`
`50`	`54`	`return "", xerrors.Errorf("get logo URL: %w", err)`
`51`	`55`	`}`
	`56`	`+`
	`57`	`+ if logoURL == "" {`
	`58`	`+ logoURL = notificationsDefaultLogoURL`
	`59`	`+ }`
`52`	`60`	`return logoURL, nil`
`53`	`61`	`}`