fix some failing tests

johnstcn · johnstcn · commit dc69c4a2ccf1 · 2023-08-22T14:54:27.000Z
- add external token encryption key to YAML excludes
- ensure that secret external token encryption key is
  scrubbed from deployment values
diff --git a/coderd/deployment_test.go b/coderd/deployment_test.go
@@ -26,6 +26,7 @@ func TestDeploymentValues(t *testing.T) {
 	cfg.OIDC.EmailField.Set("some_random_field_you_never_expected")
 	cfg.PostgresURL.Set(hi)
 	cfg.SCIMAPIKey.Set(hi)
+	cfg.ExternalTokenEncryptionKey.Set("the_random_key_we_never_expected") // len:32
 
 	client := coderdtest.New(t, &coderdtest.Options{
 		DeploymentValues: cfg,
@@ -44,6 +45,7 @@ func TestDeploymentValues(t *testing.T) {
 	require.Empty(t, scrubbed.Values.OIDC.ClientSecret.Value())
 	require.Empty(t, scrubbed.Values.PostgresURL.Value())
 	require.Empty(t, scrubbed.Values.SCIMAPIKey.Value())
+	require.Empty(t, scrubbed.Values.ExternalTokenEncryptionKey.Value())
 }
 
 func TestDeploymentStats(t *testing.T) {
diff --git a/codersdk/deployment_test.go b/codersdk/deployment_test.go
@@ -57,6 +57,9 @@ func TestDeploymentValues_HighlyConfigurable(t *testing.T) {
 		"SCIM API Key": {
 			yaml: true,
 		},
+		"External Token Encryption Key": {
+			yaml: true,
+		},
 		// These complex objects should be configured through YAML.
 		"Support Links": {
 			flag: true,
