chore: unauthorized -> forbidden for non authentication failures

Emyrk · Emyrk · commit de797e6f46de · 2023-08-30T10:08:50.000-05:00
diff --git a/coderd/workspaceapps/proxy.go b/coderd/workspaceapps/proxy.go
@@ -256,8 +256,8 @@ func (s *Server) handleAPIKeySmuggling(rw http.ResponseWriter, r *http.Request,
 func (s *Server) workspaceAppsProxyPath(rw http.ResponseWriter, r *http.Request) {
 	if s.DisablePathApps {
 		site.RenderStaticErrorPage(rw, r, site.ErrorPageData{
-			Status:       http.StatusUnauthorized,
-			Title:        "Unauthorized",
+			Status:       http.StatusForbidden,
+			Title:        "Forbidden",
 			Description:  "Path-based applications are disabled on this Coder deployment by the administrator.",
 			RetryEnabled: false,
 			DashboardURL: s.DashboardURL.String(),
diff --git a/coderd/workspaces.go b/coderd/workspaces.go
@@ -359,7 +359,7 @@ func (api *API) postWorkspacesByOrganization(rw http.ResponseWriter, r *http.Req
 	}
 
 	if organization.ID != template.OrganizationID {
-		httpapi.Write(ctx, rw, http.StatusUnauthorized, codersdk.Response{
+		httpapi.Write(ctx, rw, http.StatusForbidden, codersdk.Response{
 			Message: fmt.Sprintf("Template is not in organization %q.", organization.Name),
 		})
 		return

Original file line number	Diff line number	Diff line change
`@@ -359,7 +359,7 @@ func (api API) postWorkspacesByOrganization(rw http.ResponseWriter, r http.Req`
`359`	`359`	`}`
`360`	`360`
`361`	`361`	`if organization.ID != template.OrganizationID {`
`362`		`- httpapi.Write(ctx, rw, http.StatusUnauthorized, codersdk.Response{`
	`362`	`+ httpapi.Write(ctx, rw, http.StatusForbidden, codersdk.Response{`
`363`	`363`	`Message: fmt.Sprintf("Template is not in organization %q.", organization.Name),`
`364`	`364`	`})`
`365`	`365`	`return`